Toolchain Editor UX Improvements

This is the MR for the similarly-named milestone (and the last milestone!)

added 1 commit

• c2bb9d2a - let user click on output/input to create conn, closes #79 (closed)

Compare with previous version

added 1 commit

• 8cc308f8 - shrink zoom adjustment level, #115 (closed)

Compare with previous version

added 1 commit

• 6f87c633 - updated tc block editor to have save/cancel func, fixes #129 (closed) and #134 (closed), maybe #110 (closed)

Compare with previous version

added 1 commit

• 0e54ddf2 - added some help text for InsertObjectModal, closes #44 (closed)

Compare with previous version

added 2 commits

• 6f34ae53 - updated tc help info, closes #125 (closed)
• 2e95f4b8 - can now create an algorithm from a tc block/analyzer, closes #117 (closed)

Compare with previous version

@flavio.tarsetti could you check this and #36 (closed)?

@jdiefenbaugh : can you give me a test protocol for all the bugs it targets please ? Thanks.

And please don't forget to merge !30 (merged) on dev as it only adds non-existing tests and this MR is pending for a while now. (Note: don't click on the Comment & close merge request like last time as this closes without merging it, the merge button is at the top) Thanks

• #134 (closed): The block edit modal shouldn't save automatically, letting you cancel your changes. The user needs to click the "Save Changes" button. Things should save & update in the toolchain properly (connections too).
• #129 (closed): Given two inputs or two outputs with different names, you should be able to change the name of the second input/output to the first input/output, and then change the name of the first input/output to the old name of the second input/output. Basically making sure that the editor accepts it when you switch the names.
• #125 (closed): Make sure that the content of the "See Help" modal is up-to-date.
• #117 (closed): You should be able to create an algorithm from a normal/analyzer block in the toolchain (via the new stuff in the block editor modal) and it should intelligently create groups based on the connections to the block and fill in the groups with the input/output names.
• #115 (closed): Zooming should be incremental enough to not lose track of the toolchain
• #110 (closed): This is just a placeholder bug for this MR (all the toolchain editor UX work)
• #100 (closed): This one actually should already be closed, we decided we weren't doing this
• #79 (closed): You should be able to create connections by clicking on an output black rectangle and then clicking on an input black rectangle, in addition to the drag-and-drop method.
• #44 (closed): There should be help text explaining how to use the insert object modal (both in the insert object modal and in the help modal).

Just merged !30 (merged), made sure not to close it haha

#134 (closed) validated but it's good to mention that it's saved as local changes. The user needs to click the "Save changes" twice (once in the box) for local changes BUT important to keep in mind that he needs to click the other "Save Changes (Changes are Valid)" to really save everything before the user quits the toolchain

#129 (closed) is buggy. When doing it many times when I invert the names of the input several times. It gets confused and it automatically copies only one name... (To be fixed)

more info:

#134 (closed) see above

#129 (closed) see above: additional information: actually just by replacing the "lda_machine" by "measurements" and "measurements" by "lda_machine" in the iris/1 toolchain you can see how to reproduce this issue

#125 (closed) ok: checked the additional text added

#117 (closed) ok: was able to generate new algorithm from the new stuff from the toolchain

#115 (closed) ok: incremental zooming

#110 (closed) : dummy bug

#79 (closed) ok: was able to create connections by clicking one input and one output

#44 (closed): is this the same as #125 (closed) ? I don't see any difference with "master" when I insert a new object in the toolchain. I need more info on this one

In addition to that #170 (closed) is a real blocker to be checked too

added 1 commit

• a1ae88ce - fix input/output switching in tc modal, #129 (closed)

Compare with previous version

Okay fixed #129 (closed), could you check it again?

Also for #44 (closed) it is basically part of #125 (closed). You'll see some info in the help modal, but also a bit of info at the top of the insert object modal.

@flavio.tarsetti could you check this even though the CI is failing? The CI is broken but the branch isn't, see #172 (closed)

@jdiefenbaugh: sorry but #129 (closed) still fails

Steps to reproduce the bug:

1. Clone test/iris/1
2. In testing_alg invert lda_machine with measurements

Everything becomes lda_machine.

Enjoy!

added 1 commit

• d8faed66 - fix input/output switching in tc modal, closes #129 (closed)

Compare with previous version

@flavio.tarsetti okay haha finally fixed it (fingers crossed)

mentioned in issue #170 (closed)

@flavio.tarsetti i think #170 (closed) was accidentally fixed in this MR, so please go ahead and check it out

@jdiefenbaugh #129 (closed) seems to be fixed. I was not able to reproduce the #170 (closed) issue. But I will let @zmostaani confirm this.

In the meantime I will merge this now.

unmarked as a Work In Progress

mentioned in commit 3acbb40e

merged

mentioned in issue #115 (closed)

mentioned in issue #100 (closed)

mentioned in issue #110 (closed)