Skip to content
Snippets Groups Projects
Commit 751a38bc authored by Daniel CARRON's avatar Daniel CARRON :b:
Browse files

[test] Ignore edge values when comparing histograms

parent 3a3775e7
No related branches found
No related tags found
3 merge requests!19Fix Issues when running tests on the CI,!18Update tests,!16Make square centre-padding a model transform
Pipeline #84248 failed
...@@ -75,7 +75,11 @@ class Pasa(pl.LightningModule): ...@@ -75,7 +75,11 @@ class Pasa(pl.LightningModule):
self.model_transforms = [ self.model_transforms = [
Grayscale(), Grayscale(),
SquareCenterPad(), SquareCenterPad(),
torchvision.transforms.Resize(512, antialias=True), torchvision.transforms.Resize(
512,
antialias=True,
interpolation=torchvision.transforms.InterpolationMode.BILINEAR,
),
] ]
self._train_loss = train_loss self._train_loss = train_loss
......
...@@ -203,7 +203,9 @@ class DatabaseCheckers: ...@@ -203,7 +203,9 @@ class DatabaseCheckers:
# __import__("pdb").set_trace() # __import__("pdb").set_trace()
@staticmethod @staticmethod
def check_image_quality(datamodule, reference_histogram_file): def check_image_quality(
datamodule, reference_histogram_file, histogram_edges_threshold=2
):
ref_histogram_splits = JSONDatabaseSplit(reference_histogram_file) ref_histogram_splits = JSONDatabaseSplit(reference_histogram_file)
for split_name in ref_histogram_splits: for split_name in ref_histogram_splits:
...@@ -227,7 +229,16 @@ class DatabaseCheckers: ...@@ -227,7 +229,16 @@ class DatabaseCheckers:
img = to_pil_image(image_tensor) img = to_pil_image(image_tensor)
histogram = img.histogram() histogram = img.histogram()
assert histogram == ref_hist_data # The histograms do not exacly match due to the torch resize transform
# acting differently depending on the environment.
assert (
histogram[
histogram_edges_threshold:-histogram_edges_threshold
]
== ref_hist_data[
histogram_edges_threshold:-histogram_edges_threshold
]
)
@pytest.fixture @pytest.fixture
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment