Skip to content
Snippets Groups Projects

Improve threshold calculation in ROC, DET, and Precision and Recall plots

Merged Amir MOHAMMADI requested to merge roc-fixes into master
All threads resolved!
Edited by Amir MOHAMMADI

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • With this merge request, ROC's will look sth like this:

    roc_replaymobile.pdf-1

    roc_replaymobile.pdf-2

    Not very eye pleasing but at least the dots fall on the plots!

    Before it used to look like this:

    roc_old_replaymobile.pdf-1

    roc_old_replaymobile.pdf-2

    Edited by Amir MOHAMMADI
  • Amir MOHAMMADI added 1 commit

    added 1 commit

    • 955af965 - Improve accuracy of ROC, DET, and PR plots

    Compare with previous version

  • Amir MOHAMMADI resolved all discussions

    resolved all discussions

  • Amir MOHAMMADI changed title from Roc fixes to Improve threshold calculation in ROC, DET, and Precision and Recall plots

    changed title from Roc fixes to Improve threshold calculation in ROC, DET, and Precision and Recall plots

  • Amir MOHAMMADI added 1 commit

    added 1 commit

    • 868a13b2 - Improve accuracy of ROC, DET, and PR plots

    Compare with previous version

  • Amir MOHAMMADI added 1 commit

    added 1 commit

    • 17628ba9 - Improve accuracy of ROC, DET, and PR plots

    Compare with previous version

  • Amir MOHAMMADI resolved all discussions

    resolved all discussions

  • This is ready for review.

  • Amir MOHAMMADI added 1 commit

    added 1 commit

    • 7f251905 - Improve accuracy of ROC, DET, and PR plots

    Compare with previous version

  • Amir MOHAMMADI added 1 commit

    added 1 commit

    • 5ed0b6f3 - Improve accuracy of ROC, DET, and PR plots

    Compare with previous version

  • Amir MOHAMMADI resolved all discussions

    resolved all discussions

  • Hi @bob I am changing the way thresholds are computed for roc, det, and precision_recall curves. They look more like staircases now compared to smooth (interpolated) lines that they were before. Please test this branch and do some plots with bob bio roc or bob pad roc or their equivalent det commands and compare the changes and let me know what do you think please.

  • mentioned in merge request bob.pad.base!63 (merged)

  • I will check this out this week

  • @tiago.pereira could you please merge this?

  • I didn't even had time to look at it.

    I will merge it as soon as I review it

  • @tiago.pereira I am going to merge this to get people to test this either while it's beta or after it's released.

  • Amir MOHAMMADI mentioned in commit eeed95c2

    mentioned in commit eeed95c2

  • mentioned in merge request bob.learn.em!36 (closed)

  • Please register or sign in to reply
    Loading