Skip to content
Snippets Groups Projects

Bug fix: incorrect input file reading

Merged Theophile GENTILHOMME requested to merge bugfix into master
1 unresolved thread

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 0fc6e809 - Add default parameter to generate figsize option

    Compare with previous version

  • Amir MOHAMMADI enabled an automatic merge when the pipeline for 0fc6e809 succeeds

    enabled an automatic merge when the pipeline for 0fc6e809 succeeds

  • Amir MOHAMMADI resolved all discussions

    resolved all discussions

  • 343 355
    344 def titles_option(**kwargs):
    345 '''Get the titles option for the different systems'''
    346 def custom_titles_option(func):
    356 def legends_option(**kwargs):
    357 '''Get the legends option for the different systems'''
    358 def custom_legends_option(func):
    347 359 def callback(ctx, param, value):
    348 360 if value is not None:
    349 361 value = value.split(',')
    350 ctx.meta['titles'] = value
    362 ctx.meta['legends'] = value
    351 363 return value
    352 364 return click.option(
    353 '-ts', '--titles', type=click.STRING, default=None,
    365 '-ls', '--legends', type=click.STRING, default=None,
  • Manuel Günther
  • Amir MOHAMMADI mentioned in commit 83f4f98a

    mentioned in commit 83f4f98a

  • This was set on auto merge. I didn't merge it by hand. Manuel please continue your review and Theo will address your comments on another merge request.

  • Yes, I have seen it, but I didn't want to cancel your auto merge.

    I think, these are the only two things that I found. They are minor, though, so I don't know if they need to be addressed in a new MR.

  • I think they were addressed in !60 (merged)

  • Please register or sign in to reply
    Loading