WIP: Breaking changes
Many breaking changes:
- Use a less biometric-related name for functions (setup aliases)
- Reduce package-namespace cluttering by moving elements to submodules
- Improve confidence interval and add credible region analysis support, documentation, plotting support and paired system comparison. Limited testing is available for the time being
- Reduce to a bare minimal the amount of stuff that needs to numba-fied. Everything else can be just proper Python code.
- Pin matplotlib to 3.4.x to avoid issues with multi-page PDF output with 3.5.0
Merge request reports
Activity
added 9 commits
-
cda79c35...d8723f45 - 3 commits from branch
master - 4c714ae6 - [manifest] Fix missing files
- da1b0a77 - [bob.measure.brute_force] Implement array_jit decorator correctly
- e52b0f9e - Use a less biometric-related name for functions; Add confidence interval and...
- 306a9ea7 - [bob.measure.binary] Fix math-enable docstrings
- f307973e - [bob.measure.credible_region] spacing on docstrings
- bb5ce714 - [doc] Create a dedicated section for credible intervals
Toggle commit list-
cda79c35...d8723f45 - 3 commits from branch
added 1 commit
- d62b2fea - [doc/guide] Fix doctest after import changes
added 16 commits
-
ed268139 - 1 commit from branch
master - d728ee2e - [manifest] Fix missing files
- ebd08c10 - [bob.measure.brute_force] Implement array_jit decorator correctly
- 2c7274a2 - Use a less biometric-related name for functions; Add confidence interval and...
- cf070837 - [bob.measure.binary] Fix math-enable docstrings
- c2b7a77d - [bob.measure.credible_region] spacing on docstrings
- 0e7d6b60 - [doc] Create a dedicated section for credible intervals
- 8730ccb7 - [conda] Add dependence to numba
- 480954c5 - [doc] Remove py2 exceptions
- 665eb170 - [doc] Force api to be dumped alongside existing doc tree (fix local builds)
- 9ec64930 - [binary] black-fy
- ef1d0e12 - [manifest] Fix missing files
- b437111a - [bob,doc] Multiple documentation fixes
- 464de4a2 - [doc/links.rst] Remove unused link
- d0f23ce7 - [doc/guide] Fix doctest after import changes
- d654dd55 - [ignore] Update ignore file for git
Toggle commit list-
ed268139 - 1 commit from branch
added 10 commits
- fafe85a4 - [credible region] Added implementation to return the credible region for the...
- 7ba50ade - [credible region] fixed the modifications of the implementation for the F1score
- 4b1d67d6 - [confidence_interval] Fix import
- f70730cf - [doc] Fix documentation errors
- cfc865aa - Finalize first draft of ROC/PR curve with CI visualization (and AUC estimation)
- 602d5757 - Implements paired comparison; Externalize examples; Improve ROC bound...
- b6a774a4 - [doc] Ensure precision on demonstration
- 12f9fa9a - [conda] Pin matplotlib to x.x
- 728e7711 - [tests] Add tests for bayesian CI estimation
- a93a031b - Merge branch 'antonio-merge' into 'andres-upgrades'
Toggle commit listadded 26 commits
-
a93a031b...d04c5471 - 2 commits from branch
master - d1b2a2a7 - [manifest] Fix missing files
- a7aae53d - [bob.measure.brute_force] Implement array_jit decorator correctly
- 4712a057 - Use a less biometric-related name for functions; Add confidence interval and...
- 12846970 - [bob.measure.binary] Fix math-enable docstrings
- b72c1f28 - [bob.measure.credible_region] spacing on docstrings
- 969227bb - [doc] Create a dedicated section for credible intervals
- 7b9d3bf9 - [conda] Add dependence to numba
- 68e1f682 - [doc] Remove py2 exceptions
- 9b6b14a2 - [doc] Force api to be dumped alongside existing doc tree (fix local builds)
- 2a0c54b3 - [binary] black-fy
- 42d43987 - [manifest] Fix missing files
- 4b050d67 - [bob,doc] Multiple documentation fixes
- a90442a5 - [doc/links.rst] Remove unused link
- a396d622 - [doc/guide] Fix doctest after import changes
- 9cef345c - [ignore] Update ignore file for git
- ceeee96a - [credible region] Added implementation to return the credible region for the...
- b3ace5aa - [credible region] fixed the modifications of the implementation for the F1score
- 077f6241 - [confidence_interval] Fix import
- 6abcc61c - [doc] Fix documentation errors
- 92aa1fb4 - Finalize first draft of ROC/PR curve with CI visualization (and AUC estimation)
- a4d8e6ed - Implements paired comparison; Externalize examples; Improve ROC bound...
- bdde3a06 - [doc] Ensure precision on demonstration
- 18223a01 - [conda] Pin matplotlib to x.x
- 3c7c7b53 - [tests] Add tests for bayesian CI estimation
Toggle commit list-
a93a031b...d04c5471 - 2 commits from branch
mentioned in issue bob.bio.base#165
Resolved by André AnjosI am starting to review this, might take some time as it is quite dense. Let me know if there is any part of this I should especially focus on.
Regarding the moving of elements to submodules (
bob.measure.binary,bob.measure.brute_force, etc...) do we have some idea of how many other packages will require adaptation once we merge ?Edited by Laurent COLBOIS- Last reply by André Anjos
requested review from @lcolbois
- Resolved by André Anjos
Is there a reason for having both brute_force.py and brute_force.pyx ? If so, which one is imported through
import bob.measure.brute_force? (I am guessing the.pybut I am not familiar with.pyxso I don't know) - Last reply by André Anjos
added 1 commit
- d50e2c21 - [curves,plot] Refactors roc_ci to accomodate code from precision-recall curve-making
-
I finished reviewing everything, looks good to me (I recently added a few last comments, mostly tiny things). Note that the confidence interval part is not tested (but this is mentioned in this merge request), so I tried to check the math implementation especially cautiously for those, which seems fine.
When we merge there will be a reasonable amount of adaptations to bring to at least
bob.bio.base(https://gitlab.idiap.ch/search?search=bob.measure&group_id=373&project_id=1379&scope=&search_code=true&snippets=false&repository_ref=master&nav_source=navbar) andbob.bio.face(https://gitlab.idiap.ch/search?search=bob.measure&group_id=373&project_id=1382&scope=&search_code=true&snippets=false&repository_ref=master&nav_source=navbar) removed review request for @lcolbois
added 1 commit
- 16dabb01 - [credible_region] Goes in piece with a doubt about the use of...