Resolve "The `-DBOOST_VERSION` flag has unnecessary and unwanted quotes"
Closes #58 (closed)
Merge request reports
Activity
added 1 commit
- c4a9f56a - Removed unused BOOST_VERSION macro from compiler options; removed version from…
assigned to @andre.anjos
@mguenther: your builds are not passing on Linux (at least). The macOS builds were broken until just now (I was experimenting with a new - faster - macOS builder until then). Please retry.
added 1 commit
- aaf2abae - updated pkgconfig test, where the VERSION macro was removed
For the
BOOST_VERSION
flag, which I check here, only theBOOST_VERSION
that is actually defined inside the original boost headers is used (which is just a number, not a string as has been created before this MR). You can performgrep -rn BOOST_VERSION
in order to find the locations, where it is used if you want to verify this.I am currently looking into the other
_VERSION
flags and how they are used in.cpp
and.h
files. Currently it seems that only the versions exported in the original header files of the external dependencies are actually taken into account. I will let you know about the results of this investigation.Bottom-line: This MR should be save to accept, for the remaining
_VERSION
flags, I will open MRs in the corresponding packages.mentioned in merge request bob.core!17 (merged)
@mguenther: if this is good to merge, will you please remove the
WIP
from the title?mentioned in commit fbb34ea9
Update: I have checked all packages that make use of the
_VERSION
feature. These would be:-
bob.core
: solved in bob.core!17 (merged) (only documentation) -
bob.io.audio
: solved in bob.io.audio!7 (merged) -
bob.blitz
: The parameterBLITZ_VERSION
was never used. TheBOOST_VERSION
was used from the boost header, not from the compiler command line. Nothing to be done here. -
bob.io.video
: while versions are passed on command line, this is not required (versions are actually stored in header files). It compiles fine even when versions are not passed. Nothing to be done here. -
bob.learn.em
: TheBOOST_VERSION
was used from the boost header, not from the compiler command line. Nothing to be done here.
I have found some related issues in other packages, which are independent of this one, which I have solved nevertheless:
-
bob.io.base
: solved in bob.io.base!25 (merged) -
bob.io.image
: solved in bob.io.image!41 (merged) -
bob.learn.libsvm
: solved in bob.learn.libsvm!9 (merged)
@andre.anjos Please verify in the according merge requests that I did not do anything wrong. Everything would compile with this MR merged, but the version in
bob.io.audio
would only be stored when merging bob.io.audio!7 (merged) (see above).-