Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
beat.web
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
beat
beat.web
Commits
59104e76
Commit
59104e76
authored
4 years ago
by
Samuel GAIST
Browse files
Options
Downloads
Patches
Plain Diff
[team][api] Pre-commit cleanup
parent
b73dee6c
No related branches found
No related tags found
1 merge request
!327
Refactor update creation api
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
beat/web/team/api.py
+34
-19
34 additions, 19 deletions
beat/web/team/api.py
with
34 additions
and
19 deletions
beat/web/team/api.py
+
34
−
19
View file @
59104e76
...
...
@@ -46,20 +46,21 @@ from ..common.responses import BadRequestResponse, ForbiddenResponse
from
..common.mixins
import
CommonContextMixin
#----------------------------------------------------------
#
----------------------------------------------------------
class
UserTeamListView
(
CommonContextMixin
,
generics
.
ListCreateAPIView
):
"""
Lists the team from a user and create new teams
"""
model
=
Team
serializer_class
=
SimpleTeamSerializer
writing_serializer_class
=
TeamCreationSerializer
permission_classes
=
[
permissions
.
IsAuthenticated
]
def
get_serializer
(
self
,
*
args
,
**
kwargs
):
if
self
.
request
.
method
==
'
POST
'
:
if
self
.
request
.
method
==
"
POST
"
:
self
.
serializer_class
=
self
.
writing_serializer_class
return
super
(
UserTeamListView
,
self
).
get_serializer
(
*
args
,
**
kwargs
)
...
...
@@ -69,13 +70,19 @@ class UserTeamListView(CommonContextMixin, generics.ListCreateAPIView):
if
request
.
user
==
owner
:
queryset
=
Team
.
objects
.
filter
(
owner
=
owner
)
else
:
queryset
=
Team
.
objects
.
filter
(
Q
(
owner
=
owner
),
Q
(
privacy_level
=
Team
.
PUBLIC
)
|
Q
(
privacy_level
=
Team
.
MEMBERS
,
members
=
request
.
user
)).
distinct
()
serializer
=
self
.
get_serializer
(
queryset
,
many
=
True
,
context
=
{
'
user
'
:
request
.
user
})
queryset
=
Team
.
objects
.
filter
(
Q
(
owner
=
owner
),
Q
(
privacy_level
=
Team
.
PUBLIC
)
|
Q
(
privacy_level
=
Team
.
MEMBERS
,
members
=
request
.
user
),
).
distinct
()
serializer
=
self
.
get_serializer
(
queryset
,
many
=
True
,
context
=
{
"
user
"
:
request
.
user
}
)
return
Response
(
serializer
.
data
)
#----------------------------------------------------------
#
----------------------------------------------------------
class
TeamDetailView
(
CommonContextMixin
,
generics
.
RetrieveUpdateDestroyAPIView
):
...
...
@@ -89,15 +96,15 @@ class TeamDetailView(CommonContextMixin, generics.RetrieveUpdateDestroyAPIView):
def
get_permissions
(
self
):
self
.
permission_classes
=
[
permissions
.
IsAuthenticatedOrReadOnly
]
if
self
.
request
.
method
==
'
GET
'
:
if
self
.
request
.
method
==
"
GET
"
:
self
.
permission_classes
.
append
(
HasPrivacyLevel
)
else
:
self
.
permission_classes
.
append
(
IsOwner
)
return
super
(
TeamDetailView
,
self
).
get_permissions
()
def
get_queryset
(
self
):
owner_name
=
self
.
kwargs
.
get
(
'
owner_name
'
)
team_name
=
self
.
kwargs
.
get
(
'
team_name
'
)
owner_name
=
self
.
kwargs
.
get
(
"
owner_name
"
)
team_name
=
self
.
kwargs
.
get
(
"
team_name
"
)
team
=
get_object_or_404
(
Team
,
owner__username
=
owner_name
,
name
=
team_name
)
...
...
@@ -106,21 +113,24 @@ class TeamDetailView(CommonContextMixin, generics.RetrieveUpdateDestroyAPIView):
return
team
def
get_serializer
(
self
,
*
args
,
**
kwargs
):
if
self
.
request
.
method
in
[
'
PUT
'
,
'
PATCH
'
]:
if
self
.
request
.
method
in
[
"
PUT
"
,
"
PATCH
"
]:
self
.
serializer_class
=
self
.
writing_serializer_class
return
super
(
TeamDetailView
,
self
).
get_serializer
(
*
args
,
**
kwargs
)
def
get
(
self
,
request
,
owner_name
,
team_name
):
team
=
self
.
get_queryset
()
serializer
=
self
.
serializer_class
(
team
,
context
=
{
'
user
'
:
request
.
user
})
serializer
=
self
.
serializer_class
(
team
,
context
=
{
"
user
"
:
request
.
user
})
return
Response
(
serializer
.
data
)
def
delete
(
self
,
request
,
owner_name
,
team_name
):
team
=
self
.
get_queryset
()
# Check that the team can still be deleted
if
not
(
team
.
deletable
()):
return
ForbiddenResponse
(
"
The team isn
'
t deletable (it has been used to share %d objects with its members)
"
%
team
.
total_shares
())
if
not
(
team
.
deletable
()):
return
ForbiddenResponse
(
"
The team isn
'
t deletable (it has been used to share %d objects with its members)
"
%
team
.
total_shares
()
)
team
.
delete
()
return
Response
(
status
=
status
.
HTTP_204_NO_CONTENT
)
...
...
@@ -129,29 +139,34 @@ class TeamDetailView(CommonContextMixin, generics.RetrieveUpdateDestroyAPIView):
team
=
self
.
get_queryset
()
self
.
check_object_permissions
(
request
,
team
)
serializer
=
self
.
writing_serializer_class
(
team
,
data
=
request
.
data
,
partial
=
True
)
if
not
(
serializer
.
is_valid
()):
serializer
=
self
.
writing_serializer_class
(
team
,
data
=
request
.
data
,
partial
=
True
)
if
not
(
serializer
.
is_valid
()):
return
BadRequestResponse
(
serializer
.
errors
)
db_object
=
serializer
.
save
()
result
=
{
'
name
'
:
db_object
.
name
,
'
url
'
:
reverse
(
'
api_teams:team_info
'
,
args
=
[
db_object
.
owner
.
username
,
db_object
.
name
])
"
name
"
:
db_object
.
name
,
"
url
"
:
reverse
(
"
api_teams:team_info
"
,
args
=
[
db_object
.
owner
.
username
,
db_object
.
name
]
),
}
response
=
Response
(
result
,
status
=
200
)
response
[
'
Location
'
]
=
result
[
'
url
'
]
response
[
"
Location
"
]
=
result
[
"
url
"
]
return
response
#----------------------------------------------------------
#
----------------------------------------------------------
class
TeamListView
(
CommonContextMixin
,
generics
.
ListAPIView
):
"""
List all teams of the caller
"""
model
=
Team
serializer_class
=
SimpleTeamSerializer
permission_classes
=
[
permissions
.
IsAuthenticated
]
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment