Refactor update creation api

This merge request does the following:

• Raise DRF errors rather than returning response to take advantage of the DRF exception handling mechanism
• Create serialisers for PUT request to simplify the code
• Improve validation checks in several places
• Fixes several issues in DRF infrastructure uses
• Fixes JSON fields handling
• Remove routes that do no fully qualify objects
• Implement a custom DRF exception handler that will allow to log errors
• Improve testing
• Improve permission management

added critical enhancement labels

added 86 commits

• e493e521 - 1 commit from branch master
• 8652a44e - [experiments][serializers] Pre-commit cleanup
• 1802185d - [common][utils] Pre-commit cleanup
• c5e43fca - [common][utils] Move _cmp from ListCreateExperimentsView to py3_cmp
• 77a07c89 - [common][api] Pre-commit cleanup
• 3efeff1b - [experiments][api] Make use of py3_cmp
• 0cea5f07 - [experiments][serializers] Implement ExperimentCreationSerializer
• 8d69b9d0 - [common][api] Simplify reverse args creation for view URL
• 08c286fb - [experiments][api] Use ExperimentCreationSerializer in place of custom post
• 71082882 - [databases][serializers] Pre-commit cleanup
• 0f680542 - [databases][serializers] Refactor version handling ot match other assets
• 7512a6f1 - [common][utils] Move annotation method here
• 8558c303 - [common][serializers] Use annotate_full_name method
• b57964a8 - [experiments][serializers] Use annotate_full_name
• 63b79f0b - [databases][serializers] Add declaration validation
• 08bf8f3a - [databases][tests] Add version field for concerned tests
• 22e7bbda - [databases][tests] Fix cleanup after successfull creation test
• fa593ead - [algorithms][serializers] Set beat_core_class correctly
• 5179668e - [dataformats][serializers] Pre-commit cleanup
• f8570a8d - [dataformats][serializers] Set beat_core_class correctly
• d8cc9a80 - [experiments][serializers] Set beat_core_class correctly
• a04f3790 - [libraries][serializers] Set beat_core_class correctly
• f70704b2 - [plotters][serializers] Pre-commit cleanup
• 15d30abd - [plotters][serializers] Set beat_core_class correctly
• d1575515 - [toolchains][serializers] Pre-commit cleanup
• b92b2245 - [toolchains][serializers] Set beat_core_class correctly
• 6ebde6c5 - [toolchains][test] Update declaration error check
• 1229242a - [common][api] Generate DRF exception rather that returning configured responses on error
• f65b19e2 - [common][serializers] Add declaration and version validation
• e7ebbd37 - [dataformats][tests][api] Update error codes
• cba501ec - [code][api] Pre-commit cleanup
• 788b2b84 - [api_urls] Pre-commit cleanup
• cfeb0282 - [api_urls] Remove routes giving access to object without beeing fully qualified
• a55b29b2 - [pre-commit] Exclude tests and eggs folder for bandit
• 1ee215b0 - [common][api] Implement get_object in place of get_queryset for...
• 66d7b243 - [common][api] Simplify deletion of object using perform_destroy hook
• 34c79c81 - [code][api] Use get_object in place of get_queryset
• e12bc46c - [api tests] Add missing version parameter to all tests affected by routes cleanup
• 505ef7aa - [common][serializers] Implement modification serializer
• b40eb720 - [common][api] Adapt serializer for put on RetrieveUpdateDestroyContributionView
• 1c27da4a - [dataformats][serializers] Add mod serializer
• 6f9ce276 - [dataformats][api] Remove put implementation and use serializer in place
• 98f30a30 - [dataformats][tests] Update tests for new put implementation
• 45ad3b18 - [code][serializers] Implement mod serializer
• 95c29663 - [code][api] Use mod serializer in place of custom put impementation
• 7f850b7d - [code][api] Cleanup diff entry point
• 4dadcd3d - [algorithms][serializers] Implement mod serializer
• fb384836 - [algorithms][api] Replace put with serializer
• 88e45168 - [algoritms][tests] Update tests for new put implementation
• ee2f7ccb - [libraries][serializers] Add mod serializer
• a37c6061 - [libraries][api] Replace put with serializer
• 3f78778c - [libraries][tests] Update tests for new put implementation
• 3074dac6 - [common][serializers] Implement handling of return field selection in query parameters for PUT
• 246bc8a5 - [code][serializers] Implement code field handling PUT
• e238c602 - [algorithms][tests] Add tests for field query string handling of PUT
• 5c9874bc - [dataformats][tests] Add tests for field query string handling of PUT
• df150e3e - [libraries][tests] Add tests for field query string handling of PUT
• 443b9e50 - [toolchains][api] Pre-commit cleanup
• 84bf2581 - [toolchains][api] Improve exception raising
• 110d957a - [toolchains][serializers] Add mod serializer
• b8a51751 - [toolchains][api] Replace put with serializer
• 7c3f4f5a - [toolchains][tests] Update tests for new put implementation
• 50a1a324 - [common][fields] Remove JSONSerializerField as DRF already provides such a field
• 88dfb0bf - [accounts][serializers] Pre-commit cleanup
• 8ae5ed99 - [common][serializers] Move from JSONSerializerField to standard JSONField
• 06aae393 - [common][serializers] Move from JSONSerializerField to standard JSONField
• b2bc3a1a - [common][serializers] Move from JSONSerializerField to standard JSONField
• 18ec2275 - [reports][serializers] Pre-commit cleanup
• 3422e873 - [common][fields] Add custom JSONField
• c6bba67a - [common][serializers] Replace DRF JSONField with custom version
• fa70bc45 - [databases][serializers] Replace DRF JSONField with custom version
• f7831dba - [experiments][serializers] Replace DRF JSONField with custom version
• 7fc97794 - [plotters][serializers] Replace DRF JSONField with custom version
• 3cc24a57 - [reports][serializers] Replace DRF JSONField with custom version
• dbd744d8 - [common][serializers] Fix fork_of field type
• f6100f59 - [experiments][serializers] Fix fork_of field type
• 7e9c701e - [common][utils] annotate_full_name on query rather than starting on class
• 664d7475 - [common][serializers] Update code using annotate_full_name
• cb0e5500 - [experiments][serializers] Update code using annotate_full_name
• ab4b4b83 - [utils] Implement DRF custom exception handler
• 31c66448 - [team][api] Pre-commit cleanup
• 9628dbba - [team][api] Implement get_object in place of get_queryset for TeamDetailView
• 57c02c31 - [team][api] Implement get_serializer_context in TeamDetailView
• 56e8d9d3 - [team][api] Replace custom delete with perform_destroy hook
• 0301bfc4 - [team][api] Make serializer raise exception on validation
• 0c44930b - [team][api] Python3 "super" use cleanup

Compare with previous version

cc @flavio.tarsetti

Please take a thorough look before merging.

I know that not everything is completely covered by this merge request but the main points related to the use of beat/beat.cmdline>.

marked as a Work In Progress

changed the description

added 94 commits

• 8734acf4 - [experiments][serializers] Pre-commit cleanup
• 85bd30d3 - [common][utils] Pre-commit cleanup
• 00b616b7 - [common][utils] Move _cmp from ListCreateExperimentsView to py3_cmp
• b4cfd16d - [common][api] Pre-commit cleanup
• 7ab0e0fe - [experiments][api] Make use of py3_cmp
• 9d8e039c - [experiments][serializers] Implement ExperimentCreationSerializer
• 5fd530a1 - [common][api] Simplify reverse args creation for view URL
• 7ba642f8 - [experiments][api] Use ExperimentCreationSerializer in place of custom post
• 7de77d54 - [databases][serializers] Pre-commit cleanup
• ea16ced5 - [databases][serializers] Refactor version handling ot match other assets
• 965a5ecd - [common][utils] Move annotation method here
• 1820b8bd - [common][serializers] Use annotate_full_name method
• cef38c7b - [experiments][serializers] Use annotate_full_name
• bf46da0b - [databases][serializers] Add declaration validation
• 456ce991 - [databases][tests] Add version field for concerned tests
• 66080c5f - [databases][tests] Fix cleanup after successfull creation test
• 571abe48 - [algorithms][serializers] Set beat_core_class correctly
• b63d0f9a - [dataformats][serializers] Pre-commit cleanup
• 0cc3507f - [dataformats][serializers] Set beat_core_class correctly
• 1e049158 - [experiments][serializers] Set beat_core_class correctly
• aff98e75 - [libraries][serializers] Set beat_core_class correctly
• ca17a12b - [plotters][serializers] Pre-commit cleanup
• daf54454 - [plotters][serializers] Set beat_core_class correctly
• 8ef10d62 - [toolchains][serializers] Pre-commit cleanup
• 36eeda76 - [toolchains][serializers] Set beat_core_class correctly
• 911f2140 - [toolchains][test] Update declaration error check
• fc75fb8b - [common][api] Generate DRF exception rather that returning configured responses on error
• 29771197 - [common][serializers] Add declaration and version validation
• 80b6a180 - [dataformats][tests][api] Update error codes
• 13d86fb6 - [code][api] Pre-commit cleanup
• 89b754c8 - [api_urls] Pre-commit cleanup
• ccd466d5 - [api_urls] Remove routes giving access to object without beeing fully qualified
• b36f2265 - [pre-commit] Exclude tests and eggs folder for bandit
• fa4f375b - [common][api] Implement get_object in place of get_queryset for...
• f5cf4ac7 - [common][api] Simplify deletion of object using perform_destroy hook
• 5bb1c1b9 - [code][api] Use get_object in place of get_queryset
• a075f1d2 - [api tests] Add missing version parameter to all tests affected by routes cleanup
• 18b7a932 - [common][serializers] Implement modification serializer
• 53e94d34 - [common][api] Adapt serializer for put on RetrieveUpdateDestroyContributionView
• 8c321123 - [dataformats][serializers] Add mod serializer
• ac954c8e - [dataformats][api] Remove put implementation and use serializer in place
• 2caff54e - [dataformats][tests] Update tests for new put implementation
• 64a557dc - [code][serializers] Implement mod serializer
• 019e7b77 - [code][api] Use mod serializer in place of custom put impementation
• 20ec558d - [code][api] Cleanup diff entry point
• 6b3dfe4e - [algorithms][serializers] Implement mod serializer
• 15e3de46 - [algorithms][api] Replace put with serializer
• 4a13271b - [algoritms][tests] Update tests for new put implementation
• 54200d2f - [libraries][serializers] Add mod serializer
• 921b1e45 - [libraries][api] Replace put with serializer
• 2fb0a155 - [libraries][tests] Update tests for new put implementation
• 68a566f0 - [common][serializers] Implement handling of return field selection in query parameters for PUT
• c9d8ebad - [code][serializers] Implement code field handling PUT
• 464d28ca - [algorithms][tests] Add tests for field query string handling of PUT
• 58e1c31d - [dataformats][tests] Add tests for field query string handling of PUT
• 38e9c0a1 - [libraries][tests] Add tests for field query string handling of PUT
• c1cf7795 - [toolchains][api] Pre-commit cleanup
• 2d25248e - [toolchains][api] Improve exception raising
• ef6a96ac - [toolchains][serializers] Add mod serializer
• f60066b4 - [toolchains][api] Replace put with serializer
• af3ae551 - [toolchains][tests] Update tests for new put implementation
• aaf2bd90 - [common][fields] Remove JSONSerializerField as DRF already provides such a field
• df4b98b8 - [accounts][serializers] Pre-commit cleanup
• 61f38a34 - [common][serializers] Move from JSONSerializerField to standard JSONField
• bf292263 - [common][serializers] Move from JSONSerializerField to standard JSONField
• ebbaa257 - [common][serializers] Move from JSONSerializerField to standard JSONField
• a0d9012f - [reports][serializers] Pre-commit cleanup
• 5c28bfd8 - [common][fields] Add custom JSONField
• 05d9c7f1 - [common][serializers] Replace DRF JSONField with custom version
• 1d7e0ca7 - [databases][serializers] Replace DRF JSONField with custom version
• 83af19fe - [experiments][serializers] Replace DRF JSONField with custom version
• d7622b50 - [plotters][serializers] Replace DRF JSONField with custom version
• 7bf0ab3a - [reports][serializers] Replace DRF JSONField with custom version
• a0dab5d5 - [common][serializers] Fix fork_of field type
• 08c811a5 - [experiments][serializers] Fix fork_of field type
• cc32e3bc - [common][utils] annotate_full_name on query rather than starting on class
• 491de58a - [common][serializers] Update code using annotate_full_name
• 10c3a7b4 - [experiments][serializers] Update code using annotate_full_name
• 1007cbb0 - [utils] Implement DRF custom exception handler
• 84f0b115 - [team][api] Pre-commit cleanup
• 04ef0b7d - [team][api] Implement get_object in place of get_queryset for TeamDetailView
• 5fc28dc7 - [team][api] Implement get_serializer_context in TeamDetailView
• 96203c44 - [team][api] Replace custom delete with perform_destroy hook
• fd222184 - [team][api] Make serializer raise exception on validation
• 8c136bb3 - [team][api] Python3 "super" use cleanup
• 0e9d057c - [common][permissions] Improve IsAuthor permission
• abe56ee0 - [common][permissions] Implement permissions from various mixins
• 8f7f9458 - [common][api] Move from custom permission mixins to use permissions
• 1486fe69 - [database][api] Pre-commit cleanup
• 20eaaa10 - [databases][api] Code cleanup
• 6cd1477b - [databases][api] Move from custom permission mixins to use permissions
• 08dc59c8 - [search][api] Pre-commit cleanup
• e069cef4 - [search][api] Move from permissions mixin to use permissions
• fbd6be27 - [common][mixins] Remove permission related mixins

Compare with previous version

unmarked as a Work In Progress

changed the description

@samuel.gaist : I had a look at the code. Lots of stuff. For what touches my part for the accounts, I've seen its mostly some "pre-commit cleanup" so no problem, however for the other parts, if we trust the CI, it should be fine, I am not sure how to retest all one point at a time.

For me the code refactoring on other subjects such as experiments, etc. looked good as well.

As you might have seen I have added new validations and tests to ensure things were working correctly which unearthed some other issues like the ones related to the JSONField for which we can arg that beat/beat.cmdline> might not be sending the right stuff (text VS JSON).

One thing that you might have noted is that I removed some code related to experiment deletion when either a library or an algorithm were modified. I currently don't think that these branch were ever executed but if they did it would mean that the system would have been wrong as if any asset is used by another one, it should neither be modifiable nor deletable anymore. It would also have meant that all of a sudden experiments could disappear.

One possible thing to do for even more thorough testing is to create from scratch an experiment i.e create at least one asset of each type and use them all in a new experiment, then try to modify or delete them to see if everything is still working correctly. It should still work but I may have missed something.

assigned to @flavio.tarsetti and unassigned @andre.anjos

added 1 commit

• e30abb89 - [algorithms][templates][edition] Fix fork link generation

Compare with previous version

added 100 commits

• e30abb89...e47d4ede - 5 commits from branch master
• 76aa5a5b - [experiments][serializers] Pre-commit cleanup
• fa8e7f1f - [common][utils] Pre-commit cleanup
• 1d25415a - [common][utils] Move _cmp from ListCreateExperimentsView to py3_cmp
• eff099ff - [common][api] Pre-commit cleanup
• d964519d - [experiments][api] Make use of py3_cmp
• 52d3abf8 - [experiments][serializers] Implement ExperimentCreationSerializer
• d875b78f - [common][api] Simplify reverse args creation for view URL
• 8fb375a3 - [experiments][api] Use ExperimentCreationSerializer in place of custom post
• cde65285 - [databases][serializers] Pre-commit cleanup
• 48c805a0 - [databases][serializers] Refactor version handling ot match other assets
• c9cddf1c - [common][utils] Move annotation method here
• 0cd64f85 - [common][serializers] Use annotate_full_name method
• c5722732 - [experiments][serializers] Use annotate_full_name
• a6e70237 - [databases][serializers] Add declaration validation
• e89b9dca - [databases][tests] Add version field for concerned tests
• f520f887 - [databases][tests] Fix cleanup after successfull creation test
• e2f026c6 - [algorithms][serializers] Set beat_core_class correctly
• ea0a8ed7 - [dataformats][serializers] Pre-commit cleanup
• 4934e508 - [dataformats][serializers] Set beat_core_class correctly
• 2c4bcbf4 - [experiments][serializers] Set beat_core_class correctly
• 30afd9ba - [libraries][serializers] Set beat_core_class correctly
• 52a6ca98 - [plotters][serializers] Pre-commit cleanup
• 9fdc155b - [plotters][serializers] Set beat_core_class correctly
• d4173008 - [toolchains][serializers] Pre-commit cleanup
• 009bb229 - [toolchains][serializers] Set beat_core_class correctly
• 84ba914b - [toolchains][test] Update declaration error check
• 116c1b58 - [common][api] Generate DRF exception rather that returning configured responses on error
• c098273c - [common][serializers] Add declaration and version validation
• 36be37b6 - [dataformats][tests][api] Update error codes
• 65f0d0df - [code][api] Pre-commit cleanup
• 5a1cb3d8 - [api_urls] Pre-commit cleanup
• 4b1d8e16 - [api_urls] Remove routes giving access to object without beeing fully qualified
• 87e80f50 - [pre-commit] Exclude tests and eggs folder for bandit
• 31cbe188 - [common][api] Implement get_object in place of get_queryset for...
• 4b2feaa8 - [common][api] Simplify deletion of object using perform_destroy hook
• fbd816f6 - [code][api] Use get_object in place of get_queryset
• 75ec50fa - [api tests] Add missing version parameter to all tests affected by routes cleanup
• 3c2a96b5 - [common][serializers] Implement modification serializer
• 2daaf49a - [common][api] Adapt serializer for put on RetrieveUpdateDestroyContributionView
• 215977c3 - [dataformats][serializers] Add mod serializer
• 00579b52 - [dataformats][api] Remove put implementation and use serializer in place
• 6e0bdda1 - [dataformats][tests] Update tests for new put implementation
• fa375ba0 - [code][serializers] Implement mod serializer
• 192a28ca - [code][api] Use mod serializer in place of custom put impementation
• 1d6c6025 - [code][api] Cleanup diff entry point
• 998ac8fc - [algorithms][serializers] Implement mod serializer
• 62f3ad1b - [algorithms][api] Replace put with serializer
• 10a12a66 - [algoritms][tests] Update tests for new put implementation
• b380baa0 - [libraries][serializers] Add mod serializer
• 566bbf71 - [libraries][api] Replace put with serializer
• 3a2b22b9 - [libraries][tests] Update tests for new put implementation
• 7bea2e64 - [common][serializers] Implement handling of return field selection in query parameters for PUT
• 169af7a4 - [code][serializers] Implement code field handling PUT
• 49b26635 - [algorithms][tests] Add tests for field query string handling of PUT
• 6b7681be - [dataformats][tests] Add tests for field query string handling of PUT
• ecd4e385 - [libraries][tests] Add tests for field query string handling of PUT
• 9b8dee6e - [toolchains][api] Pre-commit cleanup
• 0b0a329c - [toolchains][api] Improve exception raising
• bfc8c714 - [toolchains][serializers] Add mod serializer
• 8bd2e15d - [toolchains][api] Replace put with serializer
• e9176816 - [toolchains][tests] Update tests for new put implementation
• e7e34db1 - [common][fields] Remove JSONSerializerField as DRF already provides such a field
• b73dc898 - [accounts][serializers] Pre-commit cleanup
• 54d4b7b6 - [common][serializers] Move from JSONSerializerField to standard JSONField
• 1b98d982 - [common][serializers] Move from JSONSerializerField to standard JSONField
• cd549f3f - [common][serializers] Move from JSONSerializerField to standard JSONField
• cff5f08e - [reports][serializers] Pre-commit cleanup
• 41a6c478 - [common][fields] Add custom JSONField
• 474cd418 - [common][serializers] Replace DRF JSONField with custom version
• 8ec56769 - [databases][serializers] Replace DRF JSONField with custom version
• aa0fac2f - [experiments][serializers] Replace DRF JSONField with custom version
• 8fa986c1 - [plotters][serializers] Replace DRF JSONField with custom version
• efd66ecf - [reports][serializers] Replace DRF JSONField with custom version
• c00e509c - [common][serializers] Fix fork_of field type
• c72fd22a - [experiments][serializers] Fix fork_of field type
• 45aba802 - [common][utils] annotate_full_name on query rather than starting on class
• f31b08ea - [common][serializers] Update code using annotate_full_name
• 84ee7581 - [experiments][serializers] Update code using annotate_full_name
• 1723c46b - [utils] Implement DRF custom exception handler
• f15af3b1 - [team][api] Pre-commit cleanup
• b516a1e7 - [team][api] Implement get_object in place of get_queryset for TeamDetailView
• a41c03b9 - [team][api] Implement get_serializer_context in TeamDetailView
• ccd7c366 - [team][api] Replace custom delete with perform_destroy hook
• 617efc48 - [team][api] Make serializer raise exception on validation
• a32afe8e - [team][api] Python3 "super" use cleanup
• 39bab41c - [common][permissions] Improve IsAuthor permission
• 066127a8 - [common][permissions] Implement permissions from various mixins
• 3dc0c371 - [common][api] Move from custom permission mixins to use permissions
• 72da6afc - [database][api] Pre-commit cleanup
• b769ea82 - [databases][api] Code cleanup
• 7fd7d8ab - [databases][api] Move from custom permission mixins to use permissions
• 34d5a2b8 - [search][api] Pre-commit cleanup
• e8367f4b - [search][api] Move from permissions mixin to use permissions
• a1a140f7 - [common][mixins] Remove permission related mixins
• 3c48550e - [algorithms][templates][edition] Fix fork link generation

Compare with previous version

resolved all threads

added 97 commits

• 28d74607 - [experiments][serializers] Pre-commit cleanup
• 77c5d4ca - [common][utils] Pre-commit cleanup
• ba9513ac - [common][utils] Move _cmp from ListCreateExperimentsView to py3_cmp
• 384b4ae1 - [common][api] Pre-commit cleanup
• e8594fa2 - [experiments][api] Make use of py3_cmp
• 6826a8d5 - [experiments][serializers] Implement ExperimentCreationSerializer
• deaeb6c0 - [common][api] Simplify reverse args creation for view URL
• 71aa87aa - [experiments][api] Use ExperimentCreationSerializer in place of custom post
• d0c64053 - [databases][serializers] Pre-commit cleanup
• feb50ae4 - [databases][serializers] Refactor version handling ot match other assets
• fce0c3b0 - [common][utils] Move annotation method here
• 46a8c2db - [common][serializers] Use annotate_full_name method
• 12f7335c - [experiments][serializers] Use annotate_full_name
• ce565f66 - [databases][serializers] Add declaration validation
• caf1ac8e - [databases][tests] Add version field for concerned tests
• 171b422b - [databases][tests] Fix cleanup after successfull creation test
• 57df928f - [algorithms][serializers] Set beat_core_class correctly
• 59c0a6e7 - [dataformats][serializers] Pre-commit cleanup
• 9bfdfe70 - [dataformats][serializers] Set beat_core_class correctly
• b46174e0 - [experiments][serializers] Set beat_core_class correctly
• 98397917 - [libraries][serializers] Set beat_core_class correctly
• d4482d70 - [plotters][serializers] Pre-commit cleanup
• 96dfc0ed - [plotters][serializers] Set beat_core_class correctly
• 9fde021a - [toolchains][serializers] Pre-commit cleanup
• 5936d585 - [toolchains][serializers] Set beat_core_class correctly
• fc90a242 - [toolchains][test] Update declaration error check
• 61213a55 - [common][api] Generate DRF exception rather that returning configured responses on error
• 137f688d - [common][serializers] Add declaration and version validation
• d31a95e9 - [dataformats][tests][api] Update error codes
• c6f2fbfe - [code][api] Pre-commit cleanup
• 63f9c28a - [api_urls] Pre-commit cleanup
• 710cfc7f - [api_urls] Remove routes giving access to object without beeing fully qualified
• 4853f0a3 - [pre-commit] Exclude tests and eggs folder for bandit
• 23e9e6eb - [common][api] Implement get_object in place of get_queryset for...
• 4b6ad3c3 - [common][api] Simplify deletion of object using perform_destroy hook
• adcfbdc3 - [code][api] Use get_object in place of get_queryset
• ac2b44ac - [api tests] Add missing version parameter to all tests affected by routes cleanup
• 41e99bf2 - [common][serializers] Implement modification serializer
• dbdb00b3 - [common][api] Adapt serializer for put on RetrieveUpdateDestroyContributionView
• f378b213 - [dataformats][serializers] Add mod serializer
• 41c3e35a - [dataformats][api] Remove put implementation and use serializer in place
• 49d900bd - [dataformats][tests] Update tests for new put implementation
• 26cb5c43 - [code][serializers] Implement mod serializer
• 2caa6959 - [code][api] Use mod serializer in place of custom put impementation
• af848676 - [code][api] Cleanup diff entry point
• 2784629d - [algorithms][serializers] Implement mod serializer
• 77f788c4 - [algorithms][api] Replace put with serializer
• 7ff0db89 - [algoritms][tests] Update tests for new put implementation
• 3349f716 - [libraries][serializers] Add mod serializer
• 2572f5c5 - [libraries][api] Replace put with serializer
• 9358585f - [libraries][tests] Update tests for new put implementation
• c3645414 - [common][serializers] Implement handling of return field selection in query parameters for PUT
• 648c10cc - [code][serializers] Implement code field handling PUT
• ac9d51fa - [algorithms][tests] Add tests for field query string handling of PUT
• 9323e654 - [dataformats][tests] Add tests for field query string handling of PUT
• faca7c10 - [libraries][tests] Add tests for field query string handling of PUT
• f3afcdbe - [toolchains][api] Pre-commit cleanup
• 3c18fdb9 - [toolchains][api] Improve exception raising
• b6c85776 - [toolchains][serializers] Add mod serializer
• 2b543b4a - [toolchains][api] Replace put with serializer
• 6a45bd06 - [toolchains][tests] Update tests for new put implementation
• 7cc30ca7 - [common][fields] Remove JSONSerializerField as DRF already provides such a field
• 84c28ccb - [accounts][serializers] Pre-commit cleanup
• f906ac1a - [common][serializers] Move from JSONSerializerField to standard JSONField
• 7028ab0f - [common][serializers] Move from JSONSerializerField to standard JSONField
• 07941c7a - [common][serializers] Move from JSONSerializerField to standard JSONField
• 93473e76 - [reports][serializers] Pre-commit cleanup
• ef5360f6 - [common][fields] Add custom JSONField
• 89a13b26 - [common][serializers] Replace DRF JSONField with custom version
• aa4228e7 - [databases][serializers] Replace DRF JSONField with custom version
• 6900345a - [experiments][serializers] Replace DRF JSONField with custom version
• b7cec201 - [plotters][serializers] Replace DRF JSONField with custom version
• f8271392 - [reports][serializers] Replace DRF JSONField with custom version
• 1d0f6986 - [common][serializers] Fix fork_of field type
• 2a28ae0f - [experiments][serializers] Fix fork_of field type
• 2989de41 - [common][utils] annotate_full_name on query rather than starting on class
• 9ee3c8ee - [common][serializers] Update code using annotate_full_name
• 68bb4dd9 - [experiments][serializers] Update code using annotate_full_name
• b73dee6c - [utils] Implement DRF custom exception handler
• 59104e76 - [team][api] Pre-commit cleanup
• 655636f0 - [team][api] Implement get_object in place of get_queryset for TeamDetailView
• 564205a9 - [team][api] Implement get_serializer_context in TeamDetailView
• 77cc651e - [team][api] Replace custom delete with perform_destroy hook
• e3c15db0 - [team][api] Make serializer raise exception on validation
• edf38f08 - [team][api] Python3 "super" use cleanup
• e34a2941 - [common][permissions] Improve IsAuthor permission
• 47cdc304 - [common][permissions] Implement permissions from various mixins
• 706b29b3 - [common][api] Move from custom permission mixins to use permissions
• dbbed637 - [database][api] Pre-commit cleanup
• befb3537 - [databases][api] Code cleanup
• 46a86b6c - [databases][api] Move from custom permission mixins to use permissions
• 672d7678 - [search][api] Pre-commit cleanup
• 2bea7add - [search][api] Move from permissions mixin to use permissions
• 45db9a66 - [common][mixins] Remove permission related mixins
• cc789866 - [algorithms][templates][edition] Fix fork link generation
• 0339f2b2 - [algorithms][templates][edition] Fix data handling in data generation
• 91188f67 - [experiments][static][js][pannel] Fix URL generation on fork save

Compare with previous version

LGTM, will merge now.

This MR fixes some issues with forking/saving of assets as well

merged

mentioned in commit 498bb740

@samuel.gaist : Looks like the pipeline failed. I will let you have a look at it ? It is not deployed at the moment due to the failure.