Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • bob.pipelines bob.pipelines
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 5
    • Issues 5
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • bobbob
  • bob.pipelinesbob.pipelines
  • Issues
  • #9
Closed
Open
Issue created Apr 03, 2020 by Yannick DAYER@ydayerOwner

SampleSet.insert not accepting DelayedSample objects as item

In bob/pipelines/sample.py, in the SampleSet class, the insert(self, index, item) does not accept DelayedSample objects.

(Because of the test: if not isinstance(item, Sample):.)

To solve:

  • either make DelayedSample and Sample inherit from a SampleBase class,
  • change the tests in SampleSet.insert to accept the base class an thus all Sample-like classes;

or:

  • change the tests in SampleSet.insert to accept both Sample and DelayedSample.

(Could be the same with __setitem__.)

Assignee
Assign to
Time tracking