Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in
bob.pipelines
bob.pipelines
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 4
    • Issues 4
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 1
    • Merge Requests 1
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • bob
  • bob.pipelinesbob.pipelines
  • Issues
  • #9

Closed
Open
Opened Apr 03, 2020 by Yannick DAYER@ydayer
  • Report abuse
  • New issue
Report abuse New issue

SampleSet.insert not accepting DelayedSample objects as item

In bob/pipelines/sample.py, in the SampleSet class, the insert(self, index, item) does not accept DelayedSample objects.

(Because of the test: if not isinstance(item, Sample):.)

To solve:

  • either make DelayedSample and Sample inherit from a SampleBase class,
  • change the tests in SampleSet.insert to accept the base class an thus all Sample-like classes;

or:

  • change the tests in SampleSet.insert to accept both Sample and DelayedSample.

(Could be the same with __setitem__.)

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
1
Labels
Easy
Assign labels
  • View project labels
Reference: bob/bob.pipelines#9