Resolve "Follow-up from "WIP: rPPG as features for PAD""
Closes #23 (closed)
Merge request reports
Activity
added 1 commit
- b7c66d42 - resolved follow-up discussion related to MR 53
To see what you are changing with this MR and the old one. Let's compare this branch against master before you merged: https://gitlab.idiap.ch/bob/bob.pad.face/compare/48c83576b94b7ebabbe29eb66363999c241a7352...23-follow-up-from-wip-rppg-as-features-for-pad
I think that all the points raised related to
have been addressed in this branch. @amohammadi could you have a look ? thanks !
We need to wait for the macs CI anyway ...
assigned to @amohammadi
-
LGTM @heusch . I would rename the Li classes (there are two) to something that conveys their functionality but if you don't want to do that it's ok too. Please merge only when it is green.
assigned to @heusch
added 1 commit
- decee648 - [preprocessor, extractor, test] changed classe names refferring to Li ICPR 2016 algorithm
added 1 commit
- 506c96b6 - [conda] unpinned the version of bob.rppg.base
added 1 commit
- 0b14d7c8 - [doc] added some documentation for pulse-based PAD
added 1 commit
- 25a472d0 - [doc] added some documentation for pulse-based PAD
-
Alright, I changed the class names, and added some documentation as well. Everything looks fine, so I think I can merge this one.
@amohammadi all good with you ?
added 1 commit
- 4308c61e - pinned the bob.rppg.base version to >= 2.0.0
added 1 commit
- 0a012481 - pinned the bob.rppg.base version to >= 2.0.0
mentioned in commit 55a11e79