Follow-up from "WIP: rPPG as features for PAD"
The following discussions from !53 (merged) should be addressed:
-
@amohammadi started a discussion: pls clean up the code here and change prints to logger.debug information.
-
@amohammadi started a discussion: There is no code under these comments.
-
@amohammadi started a discussion: same here.
-
@amohammadi started a discussion: pls remove these comments
-
@amohammadi started a discussion: pls pass kwargs to the init method here.
-
@amohammadi started a discussion: pls pass kwargs to the init method here.
-
@amohammadi started a discussion: (+1 comment) You need to put these classes in the appropriate method below
-
@amohammadi started a discussion: Why did you add this file? I think this was moved by @onikisins before.
-
@amohammadi started a discussion: Li is not a very descriptive name
-
@amohammadi started a discussion: I thought we are going to depend on bob.rppg.base only, no?
-
@amohammadi started a discussion: same here not appropiated
-
@amohammadi started a discussion: I don't see this script being added in this MR. Why are you adding an entry point here?