Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • bob.pad.face bob.pad.face
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • bobbob
  • bob.pad.facebob.pad.face
  • Issues
  • #23
Closed
Open
Issue created Jul 03, 2018 by Amir MOHAMMADI@amohammadiOwner12 of 12 checklist items completed12/12 checklist items

Follow-up from "WIP: rPPG as features for PAD"

The following discussions from !53 (merged) should be addressed:

  • @amohammadi started a discussion:

    pls clean up the code here and change prints to logger.debug information.

  • @amohammadi started a discussion:

    There is no code under these comments.

  • @amohammadi started a discussion:

    same here.

  • @amohammadi started a discussion:

    pls remove these comments

  • @amohammadi started a discussion:

    pls pass kwargs to the init method here.

  • @amohammadi started a discussion:

    pls pass kwargs to the init method here.

  • @amohammadi started a discussion: (+1 comment)

    You need to put these classes in the appropriate method below

  • @amohammadi started a discussion:

    Why did you add this file? I think this was moved by @onikisins before.

  • @amohammadi started a discussion:

    Li is not a very descriptive name

  • @amohammadi started a discussion:

    I thought we are going to depend on bob.rppg.base only, no?

  • @amohammadi started a discussion:

    same here not appropiated

  • @amohammadi started a discussion:

    I don't see this script being added in this MR. Why are you adding an entry point here?

Edited Jul 04, 2018 by Guillaume HEUSCH
Assignee
Assign to
Time tracking