Added face detection option to VideoFaceCrop preprocessor + unit tests for IQM-GMM algo.
Merge request reports
Activity
mentioned in commit b0a14393
@onikisins we discussed allowing others to review the merge requests and not merging them yourself ...
@amohammadi I think a "reasonable trade-off" is needed with assigning MRs to others. If changes are minor, according to authors opinion, there is no need of wasting time of both contributor and reviewer. If you still want to review the MR, you are welcome to open an issue in case of problem.
@onikisins I agree. These changes, however, are not minor. You changed 7 files in total, and some of the changes are not perfect.
As a minor change, I would see the fix of a misspelled word in the documentation, or a typo in the source code. Adding functionality should definitely be reviewed by someone else.
Edited by Manuel Günther12 12 bob.io.image 13 13 bob.ip.color 14 14 bob.ip.qualitymeasure 15 bob.ip.dlib @mguenther thank you for your valuable comments. Will definitely add bob.ip.dlib to develop.cfg . However, I am not sure about your comment on bool. Based on this bool is a class: https://docs.python.org/3.5/library/functions.html#bool Have I misunderstood you? Thanks!