Resolve "bob.math.linsolve parameter documentation in inconsistent order"
Merged
requested to merge 1-bob-math-linsolve-parameter-documentation-in-inconsistent-order into master
Closes #1 (closed)
When accepting this, there are two dependent packages, which need to be modified (basically, the last two parameters need to be exchanged):
bob.measure
:
bob::math::linsolve_(XY, seg, one);
-> bob::math::linsolve_(XY, one, seg);
https://gitlab.idiap.ch/bob/bob.measure/blob/master/bob/measure/cpp/error.cpp#L365
bob.learn.em
:
bob::math::linsolve(tacc_Nij_wij2_c, Tt_c, tacc_Fnormij_wij_c);
-> bob::math::linsolve(tacc_Nij_wij2_c, tacc_Fnormij_wij_c, Tt_c);
https://gitlab.idiap.ch/bob/bob.learn.em/blob/master/bob/learn/em/cpp/IVectorTrainer.cpp#L173
bob::math::linsolve(m_tmp_tt, ivector, m_tmp_t1);
-> bob::math::linsolve(m_tmp_tt, m_tmp_t1, ivector);
https://gitlab.idiap.ch/bob/bob.learn.em/blob/master/bob/learn/em/cpp/IVectorMachine.cpp#L249
This also includes breaking the API of this package and, hence, a new major version.