Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • bob.math bob.math
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • bobbob
  • bob.mathbob.math
  • Merge requests
  • !13

Resolve "bob.math.linsolve parameter documentation in inconsistent order"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Manuel Günther requested to merge 1-bob-math-linsolve-parameter-documentation-in-inconsistent-order into master Jun 06, 2017
  • Overview 18
  • Commits 7
  • Pipelines 5
  • Changes 15

Closes #1 (closed)

When accepting this, there are two dependent packages, which need to be modified (basically, the last two parameters need to be exchanged):

  • bob.measure:

    • bob::math::linsolve_(XY, seg, one); -> bob::math::linsolve_(XY, one, seg); https://gitlab.idiap.ch/bob/bob.measure/blob/master/bob/measure/cpp/error.cpp#L365
  • bob.learn.em:

    • bob::math::linsolve(tacc_Nij_wij2_c, Tt_c, tacc_Fnormij_wij_c); -> bob::math::linsolve(tacc_Nij_wij2_c, tacc_Fnormij_wij_c, Tt_c); https://gitlab.idiap.ch/bob/bob.learn.em/blob/master/bob/learn/em/cpp/IVectorTrainer.cpp#L173

    • bob::math::linsolve(m_tmp_tt, ivector, m_tmp_t1); -> bob::math::linsolve(m_tmp_tt, m_tmp_t1, ivector); https://gitlab.idiap.ch/bob/bob.learn.em/blob/master/bob/learn/em/cpp/IVectorMachine.cpp#L249

This also includes breaking the API of this package and, hence, a new major version.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 1-bob-math-linsolve-parameter-documentation-in-inconsistent-order