Skip to content
Snippets Groups Projects

added the DR-GAN encoder as a bob.bio.base.extractor

Merged Guillaume HEUSCH requested to merge drgan-msu into master
1 unresolved thread

@tiago.pereira @amohammadi I'll let you check ..

This is the code to encode an ID based on a face image using the so-called DR-GAN.

I'm aware that's a bit ugly, but this code come from MSU and is necessary to load the model they provided.

Merge request reports

Pipeline #15931 failed

Pipeline failed for e531188e on drgan-msu

Merged by Tiago de Freitas PereiraTiago de Freitas Pereira 6 years ago (Feb 5, 2018 1:16pm UTC)

Merge details

  • Changes merged into with 93cb3528.
  • Deleted the source branch.

Pipeline #15932 failed

Pipeline failed for 93cb3528 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Hey @heusch thanks for the patch.

    Is it possible to add a simple test case? Very simple, like this one would be excellent

    https://gitlab.idiap.ch/bob/bob.ip.tensorflow_extractor/blob/7540c08923e674a3eaf257bf1dd1ad4d2140eba8/bob/ip/tensorflow_extractor/test.py#L42

    thanks

  • Guillaume HEUSCH added 2 commits

    added 2 commits

    • a434bd34 - [DR-GAN] removed the dependency to bob.bio.base.extractor
    • 73d08730 - [DR-GAN] added test for DR-GAN

    Compare with previous version

  • Tiago de Freitas Pereira resolved all discussions

    resolved all discussions

  • added 1 commit

    • fc418e59 - Organized the download mechanism

    Compare with previous version

  • added 1 commit

    • e531188e - Added the DR-GAN encoder as feature extractor

    Compare with previous version

  • Hey @heusch,

    I appended the download mechanism and wrote some documentation. Thanks for the contribution. I will run some tests in bob.bio.face_ongoing. I will let you know when I have some results. Cheers

    @amohammadi, I will open an issue to implement the download mechanism you suggested.

  • Tiago de Freitas Pereira enabled an automatic merge when the pipeline for e531188e succeeds

    enabled an automatic merge when the pipeline for e531188e succeeds

  • Tiago de Freitas Pereira canceled the automatic merge

    canceled the automatic merge

  • mentioned in commit 93cb3528

  • 320 class DrGanMSUExtractorBioBase(DrGanMSUExtractor, Extractor):
    321 pass
    322 extractor = DrGanMSUExtractorBioBase()
    323
    324
    325 **Parameters:**
    326
    327 model_file:
    328 Path to the model
    329
    330 image_size: list
    331 The input image size (WxHxC)
    332
    333 """
    334
    335 def __init__(self, model_path=None, image_size=[96, 96, 3]):
    • my suggestion was to use rc here instead of None:

      from bob.extension import rc
      #....
      def __init__(self, model_path=rc['bob.ip.tensorflow_extractor.msudrgan_dir'], image_size=[96, 96, 3]):

      or some name other than bob.ip.tensorflow_extractor.msudrgan_dir that I have written here.

    • Please register or sign in to reply
  • Amir MOHAMMADI
  • Author Maintainer

    @tiago.pereira You're welcome, and thanks for taking care of the additional burden

  • Please register or sign in to reply
    Loading