Bugfix: setting streamfile source now closes previous hdf5 file and re-reads...

Bugfix: setting streamfile source now closes previous hdf5 file and re-reads metadata only if they are defined

bob/io/stream/stream_file.py

@@ -122,15 +122,18 @@ class StreamFile:
         """
         if hdf5_file is not None:
             self.hdf5_file_path = hdf5_file
+            if self.hdf5_file is not None:  # close file if open
+                self.hdf5_file.close()
             self.hdf5_file = h5py.File(hdf5_file, mode)
-        if metadata is not None:
-            self._metadata = metadata
-            # we read the file, or we append to an already existing file and want to keep the file's metadata
-            if mode == "r" or (mode == "a" and not overwrite_metadata):
-                self.read_metadata()
-            # we write a new file, or append to an existing file but want to overwrite the file's metadata.
-            elif mode == "w" or (mode == "a" and overwrite_metadata):
-                self.write_metadata()
+
+            if metadata is not None:
+                self._metadata = metadata
+                # we read the file, or we append to an already existing file and want to keep the file's metadata
+                if mode == "r" or (mode == "a" and not overwrite_metadata):
+                    self.read_metadata()
+                # we write a new file, or append to an existing file but want to overwrite the file's metadata.
+                elif mode == "w" or (mode == "a" and overwrite_metadata):
+                    self.write_metadata()
 
     def read_metadata(self):
         """Read the metadata values from the hdf5 file and store them in `self._metadata`."""