Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • bob.io.image bob.io.image
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • bobbob
  • bob.io.imagebob.io.image
  • Issues
  • #32
Closed
Open
Issue created Jun 08, 2018 by Manuel Günther@mguentherMaintainer

versions of image libraries are evaluated by hand and given as parameters on the compiler command line

Related to bob.extension#58 (closed), there are some unnecessary parameters that are passed on the compiler command line. All the versions of the dependent libraries (JPEG, TIFF, GIFF, PNG) are estimated in setup.py and passed as a -D..._VERSION to the compilation. However, on one hand, some of these values are not used in the C++ code at all, and others can be taken directly from the original header files instead of taken from the command line.

Note that these flags are not exported to other libraries on the python level, only the HAVE_... macros are, see: https://gitlab.idiap.ch/bob/bob.io.image/blob/c8ca9cddbadd56c4386cc1327427640af383110f/bob/io/image/__init__.py#L116 Hence, there will be no side-effect in removing these definitions from the command line.

Assignee
Assign to
Time tracking