Skip to content
Snippets Groups Projects
Commit d8e3320d authored by Tiago de Freitas Pereira's avatar Tiago de Freitas Pereira
Browse files

Implemented hack for the info/files issue. Patching the copying file too

parent e9ffa187
No related branches found
No related tags found
1 merge request!113'info/LICENSE' not in info/files
Pipeline #34222 passed
......@@ -444,9 +444,14 @@ if __name__ == "__main__":
logger.warn('Replacing ../LICENSE to LICENSE (https://github.com/conda/conda-build/issues/3767)')
pwd = os.path.abspath(os.curdir)
os.symlink(f"{pwd}/LICENSE", f"{pwd}/conda/LICENSE")
  • Maintainer

    This requires at least Python 3.6.

    This will fail on stretch based machines when using the system provided Python as it is still version 3.5.

  • Please register or sign in to reply
if(os.path.exists('COPYING')):
os.symlink(f"{pwd}/COPYING", f"{pwd}/conda/COPYING")
recipe = open("./conda/meta.yaml").readlines()
recipe = [l.replace("../LICENSE","LICENSE") for l in recipe]
recipe = [l.replace("../COPYING","COPYING").replace("../LICENSE","LICENSE") for l in recipe]
open("./conda/meta.yaml", "wt").write(''.join(recipe))
#### END OF HACK
condarc = os.path.join(args.conda_root, "condarc")
......
  • Author Owner

    Yeap, but we are not supporting python < 3.6, are we?

  • Maintainer

    In fact, we are.

    Both Linux CI machines are running stretch with Python 3.5.3.

  • Owner

    The bootstrap script should support "python3". That is how it is called from the cmdline. The build environment for our packages is guaranteed to be 'python>=3.6', but the bootstrap has to work before that guarantee can be made.

  • Author Owner

    Hey @samuel.gaist, which CI ? The base python3 in our docker (linux) is python 3.6.1.

    Well, I can change the code to be python 3.x compliant, no problem

  • Owner

    Just check beat/beat.nightlies>

  • Author Owner

    ok, I saw. I'll push a fix

  • Author Owner

    Fixed. I triggered beat.nightlies seems working

    thanks

  • Maintainer

    Sorry, I didn't saw that my answer hadn't been posted. As you found out, both were concerned.

    Thanks for the fix !

0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment