Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • bob.core bob.core
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • bobbob
  • bob.corebob.core
  • Merge requests
  • !7

Resolve "Disable logging messages in pure C++ code"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Manuel Günther requested to merge 5-disable-logging-messages-in-pure-c-code into master Oct 19, 2016
  • Overview 6
  • Commits 6
  • Pipelines 2
  • Changes 6

Closes #5 (closed)

I have implemented functionality to select the log level in pure C++ code. You can now simply use bob::core::log_level(bob::core::INFO) to allow INFO messages (and above) to be printed, or bob::core::log_level(bob::core::DISABLE) to disable all C++ log output. By default, DEBUG messages are written. This functionality should only be used in pure C++ code and is, therefore, not bound to python, which has its own logging system. The interface between bob and the logging system in Python has not changed.

I have created a new bob/core/_test.so extension, which contains test cases for the new functionality. To be able to run it using nose, the test case has been bound to Python. I have also moved the existing C++-only test cases, which have been in the bob/core/_library.so into the bob/core/_test.so. Hence, the test cases are not loaded any more when running import bob.core, but only during testing.

@andre.anjos : As you have written the logging system, I assign this PR to you.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 5-disable-logging-messages-in-pure-c-code