Accept an annotator in FaceCrop

related to #26 (closed)

marked as a Work In Progress

@mguenther what do you think about something like this before I go and implement it further?

I guess it looks OK. I might be a bit lost, though, since the diff is large. I cannot verify, which of the changes are methodological changes, and which are cosmetic.

It would be more interesting to see how you handle the different preprocessors, which currently are two-layer (face crop after face detection, for example).

With this addition there would be no need for the FaceDetect class because the annotator can do that.

That's exactly what I meant with "how you handle different preprocessors". I wanted to know, how you would implement the face detection step :-)

Face detection is already implemented as an annotator. Pass it to FaceCrop here and it will act as if it is FaceDetect.

Maybe I was not clear. When you asked:

It would be more interesting to see how you handle the different preprocessors

This is already implemented. I just need to deprecate the FaceDetect class and replace its config file with something like:

preprocessor = FaceCrop(..., annotator=BobIpFlandmark())

added 4 commits

• e48a2007...182bdc83 - 2 commits from branch master
• 155ec27c - Accept an annotator in FaceCrop
• 0ace9f60 - Fix a bug when face sizes where not being validated properly

Compare with previous version

added 2 commits

• 9799d244 - Fix syntax for python 2
• 3b10cb3f - Add build folder to gitignore

Compare with previous version

unmarked as a Work In Progress

assigned to @mguenther

Thanks for also fixing my documentation. :-)

merged

mentioned in commit 8868ffcc

no problem. I use this plugin for sublimetext to automatically generate the docs template: https://github.com/KristoforMaynard/SublimeAutoDocstring

With this feature, can I stack annotators?

For instance, I want to run one annotator, if doesn't work I want to run the next one and so on.

Yes. see https://www.idiap.ch/software/bob/docs/bob/docs/master/bob.bio.base/doc/implemented.html#bob.bio.base.annotator.FailSafe

awesome :-)

Thanks

mentioned in issue #26 (closed)