Use bob.bio.base read_annotations utility

bob/bio/face/script/display_face_annotations.py

@@ -61,7 +61,7 @@ Examples:
 @click.option(
     "-x",
     "--annotations-extension",
-    default = ".json",
+    default = "json",
     show_default=True,
     help="Annotations files have the given filename extension.",
 )
@@ -193,12 +193,10 @@ def display_face_annotations(
         annotations = {}
         if annotations_dir is not None:
             # Loads the corresponding annotations file
-            annotations_file = os.path.join(annotations_dir, sample.key + annotations_extension)
+            annotations_file = os.path.join(annotations_dir, sample.key + '.' + annotations_extension)
             if os.path.exists(annotations_file):
                 logger.info("Loading annotations from file %s", annotations_file)
-                with open(annotations_file) as f: # TODO remove and use bob.db.base.read_annotations_file
-                    annotations=json.load(f)
-                # annotations = bob.db.base.read_annotation_file(annotations_file, args.annotations_type)
+                annotations = bob.db.base.read_annotation_file(annotations_file, annotations_extension)
             else:
                 logger.warn("Could not find annotation file %s", annotations_file)
         else:

[Manuel Günther]

I don't like this change. The filename extension always includes the leading ., everywhere inside of Bob and also outside. It would be better to modify the annotation_extension in line 199 instead.

[Amir MOHAMMADI]

yes, I think adding two click options: 1 for extension and 1 for type would fix this issue as well.

[Yannick DAYER]

Yes, consistency is important. I added an option to specify the type of annotations as well, that will be passed to read_annotations.

[Amir MOHAMMADI]

You need two options in here, annotation type and annotations extension

[Yannick DAYER]

Understood. It should be better now.