Skip to content
Snippets Groups Projects

Propagated the option --allow-missing-files .....

Merged Tiago de Freitas Pereira requested to merge issue-96 into master

Propagated the --allow-missing-files option to the bob.bio.base.utils._generate_features

issues #96 (closed) and bob.bio.gmm#21 (closed)

Edited by Amir MOHAMMADI

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Manuel Günther
  • @tiago.pereira this function is very vague, I only know it works because of its test cases. Please add test cases for all possible combinations of its inputs.

    Edited by Amir MOHAMMADI
  • Yes @amohammadi (read here bob.bio.gmm!13 (merged)); the thing is still WIP though.

    I will run my gigantic experiment before finish this

  • @tiago.pereira I will assign to this to you for now and please assign it to me again when you are finished. No pressure.

  • Amir MOHAMMADI added 1 commit

    added 1 commit

    • 3f78e620 - improve allow_missing_files option and add tests

    Compare with previous version

  • Amir MOHAMMADI unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Amir MOHAMMADI added 1 commit

    added 1 commit

    Compare with previous version

  • Amir MOHAMMADI added 1 commit

    added 1 commit

    • 3ba3e30f - Pass the same size as well to the lower function

    Compare with previous version

  • Amir MOHAMMADI removed assignee

    removed assignee

  • @tiago.pereira or @mguenther or somebody else this is ready.

  • Amir MOHAMMADI resolved all discussions

    resolved all discussions

  • 119 119 def reader_wrong_size(path):
    120 120 return numpy.arange(2 * path).reshape(2, path)
    121 121
    122 # test C and F readers
  • Cool, LGTM.

    I will wait a bit for the MR in bob.bio.gmm. My experiment, that uses this patch, is still running and will take around one more day to finish it. I guess there's no rush for this patch.

    Thanks

  • LGTM2. Since @tiago.pereira wants to wait, I assign this MR to him.

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading