Skip to content
Snippets Groups Projects

[widgets] Save/Restore window state and geometry

Merged Flavio TARSETTI requested to merge save_restore_window_state_geometry into v2
All threads resolved!

Save/Restore window state and geometry

This fix lets a user decide how and where the window is placed, giving him the freedom to decide how the application will appear after quitting and restoring it.

Merge request reports

Pipeline #27325 passed

Pipeline passed for fb2a2439 on save_restore_window_state_geometry

Approval is optional

Merged by Samuel GAISTSamuel GAIST 5 years ago (Feb 20, 2019 3:09pm UTC)

Merge details

  • Changes merged into v2 with 6458ebcd.
  • Deleted the source branch.

Pipeline #27329 passed

Pipeline passed for 6458ebcd on v2

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 4c099ed1 - [widgets] set app/name/organization with QApplication and set QSettings as local variable

    Compare with previous version

  • Thanks for tip! Does this look better now ?

  • added 1 commit

    • b9039306 - [widgets] removed unnecessary comment

    Compare with previous version

  • added 1 commit

    • fb2a2439 - [widgets] changed negative testing logic

    Compare with previous version

  • Done. Updated.

  • Samuel GAIST resolved all discussions

    resolved all discussions

  • merged

  • Samuel GAIST mentioned in commit 6458ebcd

    mentioned in commit 6458ebcd

  • @flavio.tarsetti is the feature in the MR summary supposed to be working now? I rebased my branches and it still doesn't save the dimensions of the window.

    Steps to reproduce:

    • On branch library-editor-178
    • ./bin/beat editor start
    • The editor pops up very small
    • I make the editor larger
    • I exit via Ctrl+Q
    • ./bin/beat editor start
    • The editor still starts very small, not remembering the size I made it
    Edited by Jaden DIEFENBAUGH
  • @jdiefenbaugh : !56 (merged) when merged will help enforce the fact that all is restored after the creation of all components.

    Your actual issue is that you are quitting via Ctrl+Q and not via the x window close that captures the event in closeEvent and saves the settings. The Ctrl+Q part is still not implemented but will be implemented soon. Please use the x for the time being, until this is implemented

  • Please register or sign in to reply
    Loading