Skip to content
Snippets Groups Projects

Improves dependence pinning on release with a specific flag

Merged Improves dependence pinning on release with a specific flag
issue-4 into main
4 unresolved threads
Merged André Anjos requested to merge issue-4 into main
4 unresolved threads

This MR closes #4 (closed) by implementing what is described on its comments: user just needs to pass the -p flag to activate pinning. The --profile is loaded as for other applications in this package, and any default profile is respected.

Edited by André Anjos

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
src/idiap_devtools/scripts/gitlab/release.py
128 154
129 155 gl = get_gitlab_instance()
130 156
131 if profile is None:
132 logger.warning(
133 "No dev-profile given. There will be no dependencies version pinning. "
134 "To enable pinning, set the --profile option."
135 )
136 else:
137 profile = validate_profile(None, None, profile)
138 logger.info(
139 "Loading profile '%s' for dependencies version pinning.", profile
140 )
141 loaded_profile = Profile(profile)
157 # 1. loads profile data
  • Samuel GAIST
    Samuel GAIST @sgaist started a thread on the diff
    • src/idiap_devtools/scripts/gitlab/release.py
    128 154
    129 155 gl = get_gitlab_instance()
    130 156
    131 if profile is None:
    132 logger.warning(
    133 "No dev-profile given. There will be no dependencies version pinning. "
    134 "To enable pinning, set the --profile option."
    135 )
    136 else:
    137 profile = validate_profile(None, None, profile)
    138 logger.info(
  • Samuel GAIST
    Samuel GAIST @sgaist started a thread on an old version of the diff
    • src/idiap_devtools/scripts/gitlab/release.py
    85 110 pipeline versions
    86 111 * Re-commits and pushes the whole with the option ``[ci skip]``.
    87 112
    88 When a dev-profile is given (with ``--profile``), the versions of the dependencies
    89 in ``pyproject.toml`` will be pinned to those of the ``constraints.txt`` file.
    113 N.B.: When the option ``pin-dependencies`` is set, the versions of the
    114 dependencies in ``pyproject.toml`` will be pinned to those of the Python
    115 ``constraints.txt`` file available in the select development profile.
  • Samuel GAIST
    Samuel GAIST @sgaist started a thread on an old version of the diff
    • src/idiap_devtools/scripts/gitlab/release.py
    223 240 tag_name=vtag,
    224 241 tag_comments=description_text,
    225 242 dry_run=dry_run,
    226 profile=loaded_profile,
    243 profile=the_profile if pin_dependencies else None,
  • André Anjos added 1 commit

    added 1 commit

    • ae4f0c77 - [scripts.gitlab.release] Resolve review points

    Compare with previous version

  • André Anjos requested review from @samuel.gaist

    requested review from @samuel.gaist

  • André Anjos
    André Anjos @aanjos ·
    Author Maintainer

    Excellent, thanks for all the comments - I'll merge it if OK now.

  • André Anjos added 2 commits

    added 2 commits

    • 778e3718 - [pyproject] Add missing pytz dependence
    • 10c86f39 - [conda] Add missing pytz dependence

    Compare with previous version

  • Samuel GAIST approved this merge request

    approved this merge request

  • André Anjos merged

    merged

  • André Anjos mentioned in commit d4cbe4cb

    mentioned in commit d4cbe4cb

    • Please register or sign in to reply