[indian] Adding missing sample

Fix #47 (closed). The sample 'DatasetA/Training/nx23.jpg' was added to the 'default' protocol and to each of the 10 folds of the 'indian' dataset. This is the only missing sample and consequently the only addition to the protocols.

added New Feature label

assigned to @ojimenez

Thanks, @ojimenez - could you explain the reasoning of the subsets where you inserted the sample at? For example, why inserting the sample at the validation set on the default evaluation protocol instead of train? (N.B.: There is no right answer - it is just for keeping the record of decisions somewhere!)

added 1 commit

• da63b596 - [indian] Balanced default training set

Compare with previous version

@andre.anjos I noticed that the subsets and the folds are balanced in the number of negatives and positives. However, looking into the default split more carefully, the missing sample fits better in the train set. I have now updated this in the default protocol and added the missing sample to the train set. The resulting default protocol now has the same amount of positive and negative cases in all of the subsets.

Regarding the folds, I added the missing sample (DatasetA/Training/nx23.jpg) in the test set of fold-0, in the train set in half of the folds, i.e. 1,3,5,7,9, and in the validation set in the remaining folds, i.e. 2,4,6,8

Thanks! I see tests are failing. Any obvious reason?

It seems the recently added sample is not found during the tests FAILED tests/test_indian.py::test_loading[default-validation] - FileNotFoundError: [Errno 2] No such file or directory: '/idiap/resource/database/TBXpredict/DatasetA/Training/nx23.jpg'

That is because we need to resync the database on the CI. I'm on a meeting and will do it afterwards.

I relaunched the synchronisation on both the Linux and macOS hosts. The following files were uploaded:

DatasetA/Training/nx23.jpg
DatasetB/Testing/nd152.dcm
DatasetB/Testing/nd153.dcm
DatasetB/Testing/nd169.dcm
DatasetB/Testing/nd234.dcm
DatasetB/Testing/nd436.dcm
DatasetB/Testing/nd858.dcm
DatasetB/Testing/pd149.dcm

added 1 commit

• f572de2a - [indian] Updated indian tests

Compare with previous version

Thanks, @ojimenez - looks merry!

merged

mentioned in commit 2ed2f09a