Merge branch 'preparing-release' into 'master'

Preparing new release

Closes #7

See merge request !13

.gitignore

@@ -72,8 +72,10 @@ doc/bob.io.video/
 doc/bob.ip.base/
 doc/bob.ip.caffe_extractor/
 doc/bob.ip.color/
+doc/bob.ip.dlib
 doc/bob.ip.draw/
 doc/bob.ip.facedetect/
+doc/bob.ip.facelandmarks/
 doc/bob.ip.flandmark/
 doc/bob.ip.gabor/
 doc/bob.ip.mtcnn/

.gitlab-ci.yml

-# This build file uses template features from YAML so it is generic enough for
-# any Bob project. Don't modify it unless you know what you're doing.
-
-# Definition of global variables (all stages)
-variables:
-  CONDA_ROOT: "${CI_PROJECT_DIR}/miniconda"
-
-
-# Definition of our build pipeline order
-stages:
-  - build
-  - deploy
-
-
-# Build targets
-.build_template: &build_job
-  stage: build
-  before_script:
-    - mkdir _ci
-    - curl --silent "https://gitlab.idiap.ch/bob/bob.admin/raw/master/gitlab/install.sh" > _ci/install.sh
-    - chmod 755 _ci/install.sh
-    - ./_ci/install.sh _ci master #installs ci support scripts
-    - ./_ci/before_build.sh
-    - ./before_build.sh
-  script:
-    - ./_ci/build.sh
-  after_script:
-    - ./_ci/after_build.sh
-  cache: &build_caches
-    paths:
-      - miniconda.sh
-      - ${CONDA_ROOT}/pkgs/*.tar.bz2
-      - ${CONDA_ROOT}/pkgs/urls.txt
-
-
-.build_linux_template: &linux_build_job
-  <<: *build_job
-  tags:
-    - docker
-  image: continuumio/conda-concourse-ci
-  artifacts:
-    expire_in: 1 week
-    paths:
-      - _ci/
-      - ${CONDA_ROOT}/conda-bld/linux-64/*.tar.bz2
-  cache:
-    <<: *build_caches
-    key: "linux-cache"
-
-
-build_linux_36:
-  <<: *linux_build_job
-  variables:
-    GITLAB_CHECKOUT_STRATEGY: "https://gitlab-ci-token:${CI_BUILD_TOKEN}@gitlab.idiap.ch/"
-    PYTHON_VERSION: "3.6"
-    BUILD_EGG: "true"
-  artifacts:
-    expire_in: 1 week
-    paths:
-      - _ci/
-      - sphinx
-      - ${CONDA_ROOT}/conda-bld/linux-64/*.tar.bz2
-
-
-# Deploy targets
-.deploy_template: &deploy_job
-  stage: deploy
-  before_script:
-    - ./_ci/install.sh _ci master #updates ci support scripts
-  script:
-    - ./_ci/deploy.sh
-  dependencies:
-    - build_linux_36
-  tags:
-    - deployer
-
-
-deploy_beta:
-  <<: *deploy_job
-  environment: beta
-  only:
-    - master
-
-
-deploy_stable:
-  <<: *deploy_job
-  environment: stable
-  only:
-    - /^v\d+\.\d+\.\d+([abc]\d*)?$/  # PEP-440 compliant version (tags)
-  except:
-    - branches
+include: 'https://gitlab.idiap.ch/bob/bob.devtools/raw/master/bob/devtools/data/gitlab-ci/docs.yaml'

before_build.sh

-#!/usr/bin/env bash
-
-set -ex
-
-# to fix cloning in docker images
-GITLAB_CHECKOUT_STRATEGY="${GITLAB_CHECKOUT_STRATEGY:-git@gitlab.idiap.ch:}"
-
-# Clone all packages
-for pkg in bob `cat requirements.txt | sed -e '/^\s*#.*/d;/^\s*$/d'`; do
-    git clone --depth 1 ${GITLAB_CHECKOUT_STRATEGY}bob/${pkg}.git doc/$pkg || \
-    { git -C doc/$pkg reset --hard HEAD && \
-    git -C doc/$pkg checkout master && \
-    git -C doc/$pkg pull; }
-    if [[ -n "${CI_COMMIT_TAG}" ]]; then
-        git -C doc/$pkg fetch --tags
-        tag=`git -C doc/$pkg tag --sort='v:refname' | grep -e 'v[0-9]*\.[0-9]*\.[0-9]*$' | tail -n 1`
-        git -C doc/$pkg checkout $tag
-    fi
-done
-
-# Create extra-intersphinx.txt
-# Add newlines in the end of files
-# remove bobs, gridtk
-# remove comments
-# remove trailing whitespace
-sed -e '$s/$/\n/' \
-    -e '/^bob/d' \
-    -e '/^gridtk/d' \
-    -e 's:#.*$::g' \
-    -e 's/[[:space:]]*$//' \
-    -s \
-    doc/*/doc/extra-intersphinx.txt \
-    doc/*/requirements.txt \
-    doc/*/test-requirements.txt \
-    | sort -u > doc/extra-intersphinx.txt
-
-# Create nitpick-exceptions.txt
-# Add newlines in the end of files
-# remove comments
-# remove trailing whitespace
-sed -e '$s/$/\n/' \
-    -e 's:#.*$::g' \
-    -e 's/[[:space:]]*$//' \
-    -s \
-    doc/*/doc/nitpick-exceptions.txt \
-    | sort -u > doc/nitpick-exceptions.txt

conda/meta.yaml

@@ -84,8 +84,10 @@ requirements:
     - bob.ip.base
     - bob.ip.caffe_extractor
     - bob.ip.color
+    - bob.ip.dlib
     - bob.ip.draw
     - bob.ip.facedetect
+    - bob.ip.facelandmarks
     - bob.ip.flandmark
     - bob.ip.gabor
     - bob.ip.mtcnn

doc/conf.py

@@ -33,7 +33,7 @@ extensions = [
 plot_basedir = None
 
 # Be picky about warnings
-nitpicky = True
+nitpicky = False
 
 # Ignores stuff we can't easily resolve on other project's sphinx manuals
 nitpick_ignore = []
@@ -129,7 +129,7 @@ pygments_style = 'sphinx'
 
 # Some variables which are useful for generated material
 project_variable = project.replace('.', '_')
-short_description = u'Building of Python/C++ extensions for Bob'
+short_description = u'Bob (All Packages)'
 owner = [u'Idiap Research Institute']
 
 

doc/index.rst

@@ -34,9 +34,11 @@ Signal, Audio, Image and Video Processing
 * :ref:`bob.ip.draw`
 * :ref:`bob.ip.gabor`
 * :ref:`bob.ip.facedetect`
+* :ref:`bob.ip.facelandmarks`
 * :ref:`bob.ip.optflow.liu`
 * :ref:`bob.ip.optflow.hornschunck`
 * :ref:`bob.ip.flandmark`
+* :ref:`bob.ip.dlib`
 * :ref:`bob.ip.qualitymeasure`
 * :ref:`bob.ip.skincolorfilter`
 * :ref:`bob.ip.mtcnn`
@@ -159,100 +161,102 @@ Index of all Packages
    :maxdepth: 1
    :titlesonly:
 
-   bob <bob/doc/index.rst>
-   bob.ap <bob.ap/doc/index.rst>
-   bob.bio.base <bob.bio.base/doc/index.rst>
-   bob.bio.caffe_face <bob.bio.caffe_face/README.rst>
-   bob.bio.face <bob.bio.face/doc/index.rst>
-   bob.bio.gmm <bob.bio.gmm/doc/index.rst>
-   bob.bio.spear <bob.bio.spear/doc/index.rst>
-   bob.bio.vein <bob.bio.vein/doc/index.rst>
-   bob.bio.video <bob.bio.video/doc/index.rst>
-   bob.blitz <bob.blitz/doc/index.rst>
-   bob.buildout <bob.buildout/doc/index.rst>
-   bob.core <bob.core/doc/index.rst>
-   bob.db.arface <bob.db.arface/doc/index.rst>
-   bob.db.asvspoof <bob.db.asvspoof/doc/index.rst>
-   bob.db.asvspoof2017 <bob.db.asvspoof2017/doc/index.rst>
-   bob.db.atnt <bob.db.atnt/doc/index.rst>
-   bob.db.atvskeystroke <bob.db.atvskeystroke/doc/index.rst>
-   bob.db.avspoof <bob.db.avspoof/doc/index.rst>
-   bob.db.banca <bob.db.banca/doc/index.rst>
-   bob.db.base <bob.db.base/doc/index.rst>
-   bob.db.biosecure <bob.db.biosecure/doc/index.rst>
-   bob.db.biosecurid.face <bob.db.biosecurid.face/doc/index.rst>
-   bob.db.casme2 <bob.db.casme2/doc/index.rst>
-   bob.db.caspeal <bob.db.caspeal/doc/index.rst>
-   bob.db.cbsr_nir_vis_2 <bob.db.cbsr_nir_vis_2/README.rst>
-   bob.db.cohface <bob.db.cohface/doc/index.rst>
-   bob.db.cuhk_cufs <bob.db.cuhk_cufs/doc/index.rst>
-   bob.db.cuhk_cufsf <bob.db.cuhk_cufsf/README.rst>
-   bob.db.frgc <bob.db.frgc/doc/index.rst>
-   bob.db.fv3d <bob.db.fv3d/doc/index.rst>
-   bob.db.gbu <bob.db.gbu/doc/index.rst>
-   bob.db.hci_tagging <bob.db.hci_tagging/doc/index.rst>
-   bob.db.ijba <bob.db.ijba/doc/index.rst>
-   bob.db.ijbc <bob.db.ijbc/README.rst>
-   bob.db.iris <bob.db.iris/doc/index.rst>
-   bob.db.kboc16 <bob.db.kboc16/doc/index.rst>
-   bob.db.lfw <bob.db.lfw/doc/index.rst>
-   bob.db.livdet2013 <bob.db.livdet2013/doc/index.rst>
-   bob.db.maskattack <bob.db./doc/index.rst>
-   bob.db.mnist <bob.db.mnist/doc/index.rst>
-   bob.db.mobio <bob.db.mobio/doc/index.rst>
-   bob.db.msu_mfsd_mod <bob.db.msu_mfsd_mod/doc/index.rst>
-   bob.db.multipie <bob.db.multipie/doc/index.rst>
-   bob.db.nist_sre12 <bob.db.nist_sre12/doc/index.rst>
-   bob.db.nivl <bob.db.nivl/README.rst>
-   bob.db.oulunpu <bob.db.oulunpu/doc/index.rst>
-   bob.db.pericrosseye <bob.db.pericrosseye/doc/index.rst>
-   bob.db.pola_thermal<bob.db.pola_thermal/README.rst>
-   bob.db.putvein <bob.db.putvein/doc/index.rst>
-   bob.db.replay <bob.db.replay/doc/index.rst>
-   bob.db.replaymobile <bob.db.replaymobile/doc/index.rst>
-   bob.db.scface <bob.db.scface/doc/index.rst>
-   bob.db.utfvp <bob.db.utfvp/doc/index.rst>
-   bob.db.uvad <bob.db.uvad/doc/index.rst>
-   bob.db.verafinger <bob.db.verafinger/doc/index.rst>
-   bob.db.voicepa <bob.db.voicepa/doc/index.rst>
-   bob.db.voxforge <bob.db.voxforge/doc/index.rst>
-   bob.db.wine <bob.db.wine/doc/index.rst>
-   bob.db.xm2vts <bob.db.xm2vts/doc/index.rst>
-   bob.db.youtube <bob.db.youtube/doc/index.rst>
-   bob.db.fargo <bob.db.fargo/doc/index.rst>
-   bob.extension <bob.extension/doc/index.rst>
-   bob.fusion.base <bob.fusion.base/doc/index.rst>
-   bob.io.audio <bob.io.audio/doc/index.rst>
-   bob.io.base <bob.io.base/doc/index.rst>
-   bob.io.image <bob.io.image/doc/index.rst>
-   bob.io.matlab <bob.io.matlab/doc/index.rst>
-   bob.io.video <bob.io.video/doc/index.rst>
-   bob.ip.base <bob.ip.base/doc/index.rst>
-   bob.ip.caffe_extractor <bob.ip.caffe_extractor/README.rst>
-   bob.ip.color <bob.ip.color/doc/index.rst>
-   bob.ip.draw <bob.ip.draw/doc/index.rst>
-   bob.ip.facedetect <bob.ip.facedetect/doc/index.rst>
-   bob.ip.flandmark <bob.ip.flandmark/doc/index.rst>
-   bob.ip.gabor <bob.ip.gabor/doc/index.rst>
-   bob.ip.mtcnn <bob.ip.mtcnn/README.rst>
-   bob.ip.optflow.hornschunck <bob.ip.optflow.hornschunck/doc/index.rst>
-   bob.ip.optflow.liu <bob.ip.optflow.liu/doc/index.rst>
-   bob.ip.qualitymeasure <bob.ip.qualitymeasure/doc/index.rst>
-   bob.ip.tensorflow_extractor <bob.ip.tensorflow_extractor/README.rst>
-   bob.ip.skincolorfilter <bob.ip.skincolorfilter/doc/index.rst>
-   bob.learn.activation <bob.learn.activation/doc/index.rst>
-   bob.learn.boosting <bob.learn.boosting/doc/index.rst>
-   bob.learn.em <bob.learn.em/doc/index.rst>
-   bob.learn.libsvm <bob.learn.libsvm/doc/index.rst>
-   bob.learn.linear <bob.learn.linear/doc/index.rst>
-   bob.learn.mlp <bob.learn.mlp/doc/index.rst>
-   bob.math <bob.math/doc/index.rst>
-   bob.measure <bob.measure/doc/index.rst>
-   bob.pad.base <bob.pad.base/doc/index.rst>
-   bob.pad.face <bob.pad.face/doc/index.rst>
-   bob.pad.vein <bob.pad.vein/doc/index.rst>
-   bob.pad.voice <bob.pad.voice/doc/index.rst>
-   bob.sp <bob.sp/doc/index.rst>
-   bob.rppg.base <bob.rppg.base/README.rst>
-   gridtk <gridtk/doc/index.rst>
+   bob <bob/bob/doc/index.rst>
+   bob.ap <bob/bob.ap/doc/index.rst>
+   bob.bio.base <bob/bob.bio.base/doc/index.rst>
+   bob.bio.caffe_face <bob/bob.bio.caffe_face/README.rst>
+   bob.bio.face <bob/bob.bio.face/doc/index.rst>
+   bob.bio.gmm <bob/bob.bio.gmm/doc/index.rst>
+   bob.bio.spear <bob/bob.bio.spear/doc/index.rst>
+   bob.bio.vein <bob/bob.bio.vein/doc/index.rst>
+   bob.bio.video <bob/bob.bio.video/doc/index.rst>
+   bob.blitz <bob/bob.blitz/doc/index.rst>
+   bob.buildout <bob/bob.buildout/doc/index.rst>
+   bob.core <bob/bob.core/doc/index.rst>
+   bob.db.arface <bob/bob.db.arface/doc/index.rst>
+   bob.db.asvspoof <bob/bob.db.asvspoof/doc/index.rst>
+   bob.db.asvspoof2017 <bob/bob.db.asvspoof2017/doc/index.rst>
+   bob.db.atnt <bob/bob.db.atnt/doc/index.rst>
+   bob.db.atvskeystroke <bob/bob.db.atvskeystroke/doc/index.rst>
+   bob.db.avspoof <bob/bob.db.avspoof/doc/index.rst>
+   bob.db.banca <bob/bob.db.banca/doc/index.rst>
+   bob.db.base <bob/bob.db.base/doc/index.rst>
+   bob.db.biosecure <bob/bob.db.biosecure/doc/index.rst>
+   bob.db.biosecurid.face <bob/bob.db.biosecurid.face/doc/index.rst>
+   bob.db.casme2 <bob/bob.db.casme2/doc/index.rst>
+   bob.db.caspeal <bob/bob.db.caspeal/doc/index.rst>
+   bob.db.cbsr_nir_vis_2 <bob/bob.db.cbsr_nir_vis_2/README.rst>
+   bob.db.cohface <bob/bob.db.cohface/doc/index.rst>
+   bob.db.cuhk_cufs <bob/bob.db.cuhk_cufs/doc/index.rst>
+   bob.db.cuhk_cufsf <bob/bob.db.cuhk_cufsf/README.rst>
+   bob.db.frgc <bob/bob.db.frgc/doc/index.rst>
+   bob.db.fv3d <bob/bob.db.fv3d/doc/index.rst>
+   bob.db.gbu <bob/bob.db.gbu/doc/index.rst>
+   bob.db.hci_tagging <bob/bob.db.hci_tagging/doc/index.rst>
+   bob.db.ijba <bob/bob.db.ijba/doc/index.rst>
+   bob.db.ijbc <bob/bob.db.ijbc/README.rst>
+   bob.db.iris <bob/bob.db.iris/doc/index.rst>
+   bob.db.kboc16 <bob/bob.db.kboc16/doc/index.rst>
+   bob.db.lfw <bob/bob.db.lfw/doc/index.rst>
+   bob.db.livdet2013 <bob/bob.db.livdet2013/doc/index.rst>
+   bob.db.maskattack <bob/bob.db./doc/index.rst>
+   bob.db.mnist <bob/bob.db.mnist/doc/index.rst>
+   bob.db.mobio <bob/bob.db.mobio/doc/index.rst>
+   bob.db.msu_mfsd_mod <bob/bob.db.msu_mfsd_mod/doc/index.rst>
+   bob.db.multipie <bob/bob.db.multipie/doc/index.rst>
+   bob.db.nist_sre12 <bob/bob.db.nist_sre12/doc/index.rst>
+   bob.db.nivl <bob/bob.db.nivl/README.rst>
+   bob.db.oulunpu <bob/bob.db.oulunpu/doc/index.rst>
+   bob.db.pericrosseye <bob/bob.db.pericrosseye/doc/index.rst>
+   bob.db.pola_thermal<bob/bob.db.pola_thermal/README.rst>
+   bob.db.putvein <bob/bob.db.putvein/doc/index.rst>
+   bob.db.replay <bob/bob.db.replay/doc/index.rst>
+   bob.db.replaymobile <bob/bob.db.replaymobile/doc/index.rst>
+   bob.db.scface <bob/bob.db.scface/doc/index.rst>
+   bob.db.utfvp <bob/bob.db.utfvp/doc/index.rst>
+   bob.db.uvad <bob/bob.db.uvad/doc/index.rst>
+   bob.db.verafinger <bob/bob.db.verafinger/doc/index.rst>
+   bob.db.voicepa <bob/bob.db.voicepa/doc/index.rst>
+   bob.db.voxforge <bob/bob.db.voxforge/doc/index.rst>
+   bob.db.wine <bob/bob.db.wine/doc/index.rst>
+   bob.db.xm2vts <bob/bob.db.xm2vts/doc/index.rst>
+   bob.db.youtube <bob/bob.db.youtube/doc/index.rst>
+   bob.db.fargo <bob/bob.db.fargo/doc/index.rst>
+   bob.extension <bob/bob.extension/doc/index.rst>
+   bob.fusion.base <bob/bob.fusion.base/doc/index.rst>
+   bob.io.audio <bob/bob.io.audio/doc/index.rst>
+   bob.io.base <bob/bob.io.base/doc/index.rst>
+   bob.io.image <bob/bob.io.image/doc/index.rst>
+   bob.io.matlab <bob/bob.io.matlab/doc/index.rst>
+   bob.io.video <bob/bob.io.video/doc/index.rst>
+   bob.ip.base <bob/bob.ip.base/doc/index.rst>
+   bob.ip.caffe_extractor <bob/bob.ip.caffe_extractor/README.rst>
+   bob.ip.color <bob/bob.ip.color/doc/index.rst>
+   bob.ip.dlib <bob/bob.ip.dlib/doc/index.rst>
+   bob.ip.draw <bob/bob.ip.draw/doc/index.rst>
+   bob.ip.facedetect <bob/bob.ip.facedetect/doc/index.rst>
+   bob.ip.facelandmarks <bob/bob.ip.facelandmarks/doc/index.rst>
+   bob.ip.flandmark <bob/bob.ip.flandmark/doc/index.rst>
+   bob.ip.gabor <bob/bob.ip.gabor/doc/index.rst>
+   bob.ip.mtcnn <bob/bob.ip.mtcnn/README.rst>
+   bob.ip.optflow.hornschunck <bob/bob.ip.optflow.hornschunck/doc/index.rst>
+   bob.ip.optflow.liu <bob/bob.ip.optflow.liu/doc/index.rst>
+   bob.ip.qualitymeasure <bob/bob.ip.qualitymeasure/doc/index.rst>
+   bob.ip.tensorflow_extractor <bob/bob.ip.tensorflow_extractor/README.rst>
+   bob.ip.skincolorfilter <bob/bob.ip.skincolorfilter/doc/index.rst>
+   bob.learn.activation <bob/bob.learn.activation/doc/index.rst>
+   bob.learn.boosting <bob/bob.learn.boosting/doc/index.rst>
+   bob.learn.em <bob/bob.learn.em/doc/index.rst>
+   bob.learn.libsvm <bob/bob.learn.libsvm/doc/index.rst>
+   bob.learn.linear <bob/bob.learn.linear/doc/index.rst>
+   bob.learn.mlp <bob/bob.learn.mlp/doc/index.rst>
+   bob.math <bob/bob.math/doc/index.rst>
+   bob.measure <bob/bob.measure/doc/index.rst>
+   bob.pad.base <bob/bob.pad.base/doc/index.rst>
+   bob.pad.face <bob/bob.pad.face/doc/index.rst>
+   bob.pad.vein <bob/bob.pad.vein/doc/index.rst>
+   bob.pad.voice <bob/bob.pad.voice/doc/index.rst>
+   bob.sp <bob/bob.sp/doc/index.rst>
+   bob.rppg.base <bob/bob.rppg.base/README.rst>
+   gridtk <bob/gridtk/doc/index.rst>
    readme_index.rst

doc/plot/convolve.py

-../bob.ip.caffe_extractor/doc/plot/convolve.py
\ No newline at end of file
+../bob/bob.ip.caffe_extractor/doc/plot/convolve.py
\ No newline at end of file

doc/plot/detect_faces_mtcnn.py

+../bob/bob.ip.tensorflow_extractor/doc/plot/detect_faces_mtcnn.py
\ No newline at end of file

doc/plot/detect_single_face.py

-../bob.ip.facedetect/doc/plot/detect_single_face.py
\ No newline at end of file
+../bob/bob.ip.facedetect/doc/plot/detect_single_face.py
\ No newline at end of file

doc/plot/disparity.py

-../bob.ip.gabor/doc/plot/disparity.py
\ No newline at end of file
+../bob/bob.ip.gabor/doc/plot/disparity.py
\ No newline at end of file

doc/plot/face_eyes_norm.py

-../bob.ip.base/doc/plot/face_eyes_norm.py
\ No newline at end of file
+../bob/bob.ip.base/doc/plot/face_eyes_norm.py
\ No newline at end of file

doc/plot/gaussian.py

-../bob.ip.base/doc/plot/gaussian.py
\ No newline at end of file
+../bob/bob.ip.base/doc/plot/gaussian.py
\ No newline at end of file

doc/plot/iris_lda.py

-../bob/doc/plot/iris_lda.py
\ No newline at end of file
+../bob/bob/doc/plot/iris_lda.py
\ No newline at end of file

doc/plot/iris_lda_roc.py

-../bob/doc/plot/iris_lda_roc.py
\ No newline at end of file
+../bob/bob/doc/plot/iris_lda_roc.py
\ No newline at end of file

doc/plot/plot_ISV.py

-../bob.learn.em/doc/plot/plot_ISV.py
\ No newline at end of file
+../bob/bob.learn.em/doc/plot/plot_ISV.py
\ No newline at end of file

doc/plot/plot_JFA.py

-../bob.learn.em/doc/plot/plot_JFA.py
\ No newline at end of file
+../bob/bob.learn.em/doc/plot/plot_JFA.py
\ No newline at end of file

doc/plot/plot_MAP.py

-../bob.learn.em/doc/plot/plot_MAP.py
\ No newline at end of file
+../bob/bob.learn.em/doc/plot/plot_MAP.py
\ No newline at end of file

doc/plot/plot_ML.py

-../bob.learn.em/doc/plot/plot_ML.py
\ No newline at end of file
+../bob/bob.learn.em/doc/plot/plot_ML.py
\ No newline at end of file

doc/plot/plot_Tnorm.py

-../bob.learn.em/doc/plot/plot_Tnorm.py
\ No newline at end of file
+../bob/bob.learn.em/doc/plot/plot_Tnorm.py
\ No newline at end of file

doc/plot/plot_ZTnorm.py

-../bob.learn.em/doc/plot/plot_ZTnorm.py
\ No newline at end of file
+../bob/bob.learn.em/doc/plot/plot_ZTnorm.py
\ No newline at end of file