Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • bob bob
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3
    • Issues 3
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • bobbob
  • bobbob
  • Issues
  • #29
Closed
Open
Issue created Mar 15, 2012 by André Anjos@andre.anjos💬Owner

bob.ip.Rotate needs a review

Created by: siebenkopf

The bob.ip.Rotate class needs a mayor revision. First, it expects the rotation angle in degrees (which is rather uncommon), but this is documented nowhere. The resulting rotated image is assumed to be of type float, even when the input image is uint8. I am not sure if this behavior is intended.

Furthermore, its function bob.ip.Rotate.getOutputShape(image,angle) does not use the angle member variable, but requires the angle to be specified again. There are two solutions for this last problem. Either the class is removed and only the two functions bob.ip.rotate(image,image,angle) and bob.ip.getRotatedShape(image,angle) are preserved, or the getRotatedShape(image) function uses the angle member variable. I vote for the first solution since this would mimic the bob.ip.scale(image,image,scale) function.

Assignee
Assign to
Time tracking