Skip to content
Snippets Groups Projects

Fix delayed attributes

Merged
Yannick DAYERrequested to merge
fix-delayed-attribute into master
All threads resolved!

Delayed attributes are no longer loaded when _copy_attributes is called to create a DelayedSample.

Merge request reports

Pipeline #51125 passed

Pipeline passed for 22487ed7 on fix-delayed-attribute

Approval is optional

Merged by Amir MOHAMMADIAmir MOHAMMADI May 31, 2021 (May 31, 2021 1:01pm UTC)

Merge details

  • Changes merged into master with e320416b.
  • Deleted the source branch.

Pipeline #51126 passed

Pipeline passed for e320416b on master

Deployed to py‎pi‎ Nov 3, 2021
Deployed to sta‎ble‎ Nov 3, 2021
Deployed to be‎ta‎ May 31, 2021

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Yannick DAYER added 2 commits

    added 2 commits

    • bf16514d - Move delayed_attribute fix to DelayedSample init.
    • edc9e508 - Fix delayed_attributes being loaded into SampleSet

    Compare with previous version

  • @ydayer could you please also add some tests?

  • @ydayer any feedback on this?

  • Yannick DAYER added 2 commits

    added 2 commits

    • b0454c18 - Remove the Sampleset exception in copy_attributes.
    • e07effe6 - Added delayed_attributes tests

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Amir MOHAMMADI resolved all threads

    resolved all threads

  • Amir MOHAMMADI mentioned in commit e320416b

    mentioned in commit e320416b

  • mentioned in merge request bob.bio.base!257 (closed)

  • Thanks for this feature :-)

  • mentioned in issue bob#269 (closed)

  • Please register or sign in to reply
    Loading