Search system for lapack and blas first before looking into numpy
Fixes #4 (closed)
ping @andre.anjos @mguenther
Merge request reports
Activity
It was looking at numpy before but it did not really check if those libraries were available. So it was failing when it couldn't find mkl. Why should numpy have a better version anyway?
Edited by Amir MOHAMMADIWell - NumPy, presumably, is linked against optimised versions of BLAS and LAPACK in a nice distro (ATLAS or OpenBLAS being the most common). Following it up makes good sense in my view. The problem before was there was no fallback whereas it should as you proposed. I'm just wondering about the order. IMO, we should follow NumPy's where possible.
There is another point: we shouldn't have two versions of the same library loaded into memory, if we can. That can lead to unexpected side effects (like differences in precision when comparing implementations available in this package against NumPy equivalents).
added 1 commit
- 5a678cc4 - update links and use svg badges [skip ci] [nightlies release]
added 1 commit
- b59cb5a0 - update the mailing list and issues links [skip ci]
added 8 commits
-
b59cb5a0...843fff63 - 2 commits from branch
master
- b96963cf - update links and use svg badges [skip ci] [nightlies release]
- 76b212ee - update the mailing list and issues links [skip ci]
- aa6ede04 - check if numpy libraries actually exist
- a4917965 - search for openblas after mkl
- 86df6856 - fix comment typo
- 734d2459 - make test names more verbose
Toggle commit list-
b59cb5a0...843fff63 - 2 commits from branch
assigned to @andre.anjos
@andre.anjos the changes should be to your liking now.
mentioned in commit 60253d78