Mccn extended
Adds the extendable MCCNN architecture.
Merge request reports
Activity
assigned to @heusch
@heusch Its ready from my point of view. Let me know if you have any comments.
Ok thanks,
Here are a few remarks:
- You should not use
print
statements, but us a logger instead:
import bob.core logger = bob.core.log.setup("bob.learn.pytorch") ... bob.core.log.set_verbosity_level(logger, verbosity_level) # 1, 2 or 3 logger.{warning, info, debug}('blah blah blah')
- the docstrings should be improved here https://gitlab.idiap.ch/bob/bob.learn.pytorch/compare/master...mccn_extended#73d63fa377341c19f3d3b73e46996c44b468228b_0_26 and here https://gitlab.idiap.ch/bob/bob.learn.pytorch/compare/master...mccn_extended#73d63fa377341c19f3d3b73e46996c44b468228b_0_123
Other than that, it looks good to me ! Thanks
Edited by Guillaume HEUSCH- You should not use
@heusch Added the changes.
mentioned in commit 410f58bc
I already merged, but realised that there is no documentation, could you please provide an example in the user guide ? You can have a look at what has been done here for inspiration:
https://www.idiap.ch/software/bob/docs/bob/bob.learn.pytorch/master/guide_conv_autoencoder.html
Thanks
@heusch Sure, I will add doc, but I will add the trainer as well before compiling the documentation
Please register or sign in to reply