Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • bob.learn.pytorch bob.learn.pytorch
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • bobbob
  • bob.learn.pytorchbob.learn.pytorch
  • Issues
  • #9
Closed
Open
Issue created Feb 11, 2019 by Amir MOHAMMADI@amohammadiOwner

pkgutil.extend_path should only be used in files that are shared with other Bob packages

@ssarfjoo pointed out there are these two lines in some __init__.py of this package:

# see https://docs.python.org/3/library/pkgutil.html
from pkgutil import extend_path
__path__ = extend_path(__path__, __name__)

These lines must only be put in __init__.py files which are shared with other Bob packages. For example for this package, it means that only bob/__init__.py and bob/learn/__init__.py must contain these two lines. Because theses files are shared with other Bob packages. It must not be in other __init__.py files so it should be removed from https://gitlab.idiap.ch/bob/bob.learn.pytorch/blob/f1fe9f47c7d42b34e6d660952201ea4288a07f10/bob/learn/pytorch/__init__.py and https://gitlab.idiap.ch/bob/bob.learn.pytorch/blob/f1fe9f47c7d42b34e6d660952201ea4288a07f10/bob/learn/pytorch/extractor/__init__.py because these files only exist in bob.learn.pytorch and not somewhere else.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking