Compute vad

Add Voice Activity Detection

added 1 commit

• 59c11be9 - Add VAD computation

Compare with previous version

Hi @amohammadi Can I merge new functionality (I plan to regularly add new stuff like this one), or do you want to always review it?

Hi @milos.cernak please remove the WIP: bit from your merge requests when you think they are ready to be merged. I usually look at three things: The code, the documentation, and the tests.

This one lacks a bit of documentation in the user guide with an example. I don't think you need to add an example for every function you add here but a VAD seems important enough.

added 1 commit

• dd4bef0b - Update the guide and returning UBM model formats

Compare with previous version

added 1 commit

• d052010c - Fixed doctest

Compare with previous version

OK, I added more docs.

unmarked as a Work In Progress

Hi @amohammadi could we merge it? M.

added 1 commit

• 5639642c - Updated VAD unit test

Compare with previous version

resolved all discussions

Thanks @milos.cernak

mentioned in commit e2755d8e

merged