Skip to content
Snippets Groups Projects

remove unnecessary ValueError

This ValueError just breaks the code for no apparent reason. I know that not having this makes things a bit ambiguous but I see no reason to just pick one set of annotations and construct bounding boxes from them.

Merge request reports

Pipeline #15647 failed

Pipeline failed for 42903fc7 on check

Approval is optional

Closed by Amir MOHAMMADIAmir MOHAMMADI Jan 25, 2018 (Jan 25, 2018 10:00am UTC)

Merge details

  • The changes were not merged into master.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @amohammadi Your error description "breaks the code" is not very specific. I am not sure if your changes will solve the issue, or if the issue can be solved differently, which does not require to delete a useful test.

    The reason for this test is that different types of annotations will use different ways of defining bounding boxes. If annotations are ambiguous, it is not clear, which was will be used and, therefore, I raise this exception. If you have a specific preferred way, please pass a valid source keyword.

  • @mguenther this is not useful. Many new systems return all kinds of different annotations (topleft,bottomright and leye,reye for example). All I want here is to get the bounding box without knowing what is inside annotations. All you need to do here is to mention if there are several sources available the first found source will be used.

  • Anyways, I will close this as rejected.

Please register or sign in to reply
Loading