Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • bob.ip.base bob.ip.base
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3
    • Issues 3
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • bobbob
  • bob.ip.basebob.ip.base
  • Issues
  • #14
Closed
Open
Issue created Feb 24, 2021 by Manuel Günther@mguentherMaintainer

GeomNorm and extrapolate_mask require different mask types

When looking at the two functions GeomNorm.process and extrapolate_mask for color images, two different mask types are required:

  • GeomNorm takes a 3D mask: https://gitlab.idiap.ch/bob/bob.ip.base/-/blob/a9109e06264f2e28ece3b131da9babb0365b6f36/bob/ip/base/include/bob.ip.base/GeomNorm.h#L99 (implementation here: https://gitlab.idiap.ch/bob/bob.ip.base/-/blob/a9109e06264f2e28ece3b131da9babb0365b6f36/bob/ip/base/include/bob.ip.base/GeomNorm.h#L166)
  • extrapolate_mask takes a 2D mask: https://gitlab.idiap.ch/bob/bob.ip.base/-/blob/a9109e06264f2e28ece3b131da9babb0365b6f36/bob/ip/base/include/bob.ip.base/Affine.h#L445

This is a bit inconsequent. I am not sure, why GeomNorm requires a 3D mask for color images. Each pixel will have the same visibility independent of the color channel. Thus, I would propose to reduce the mask for GeomNorm to 2D. We can also have the possibility to have both 2D and 3D masks, in case you require backward compatibility (which I could understand).

Assignee
Assign to
Time tracking