Skip to content
Snippets Groups Projects

new image and hdf5 support

Merged Tiago de Freitas Pereira requested to merge deprecation into master
1 unresolved thread

First attempt of using imageio for image support and h5py for HDF5 support.

This is still a working in progress. I hope to have definite MR by tomorrow.

closes #23 (closed)

PS: I'll open an issue on imageio to get some issues solved as soon as possible

Edited by Tiago de Freitas Pereira

Merge request reports

Pipeline #60485 passed

Pipeline passed for 20a98996 on deprecation

Test coverage 71.00% (0.00%) from 5 jobs

Merged by Amir MOHAMMADIAmir MOHAMMADI 3 years ago (Apr 25, 2022 3:23pm UTC)

Loading

Pipeline #60486 passed

Pipeline passed for cba205a8 on master

Test coverage 71.00% (0.00%) from 5 jobs
Deployed to py‎pi‎ 3 years ago
Deployed to sta‎ble‎ 3 years ago
Deployed to be‎ta‎ 3 years ago

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    Compare with previous version

  • resolved all threads

  • added 1 commit

    • b045c500 - Removed old references from the toml file

    Compare with previous version

  • I've just benchmarked this MR against several FR experiments.

    I'm posting here the most extreme one: iresnet100 on IJB-C_test1.

    Differences are slight as you can see in the table below and in the plot attached.

    I think we are good to go with this MR.

    Objections??

    [Min. criterion: EER ] Threshold on Development set `new-io`: -7.842037e-01
    =====================  =======================
    ..                     Development
    =====================  =======================
    Failure to Acquire     0.00%
    False Match Rate       3.50% (547768/15638932)
    False Non Match Rate   3.50% (685/19557)
    False Accept Rate      3.50%
    False Reject Rate      3.50%
    Half Total Error Rate  3.50%
    =====================  =======================
    [Min. criterion: EER ] Threshold on Development set `old-io`: -7.843422e-01
    =====================  =======================
    ..                     Development
    =====================  =======================
    Failure to Acquire     0.00%
    False Match Rate       3.51% (548566/15638932)
    False Non Match Rate   3.51% (686/19557)
    False Accept Rate      3.51%
    False Reject Rate      3.51%
    Half Total Error Rate  3.51%
    =====================  =======================
    

    eval_plots.pdf

    Edited by Tiago de Freitas Pereira
  • added 1 commit

    Compare with previous version

  • 40 respecting each environment's constraints.
    41 """
    79 42
    80 from sys import version_info
    43 from sys import version_info
    81 44
    82 return (version_info[0] < 3 and isinstance(s, (str, unicode))) or \
    83 isinstance(s, (bytes, str))
    45 return (version_info[0] < 3 and isinstance(s, (str, unicode))) or isinstance(
    46 s, (bytes, str)
    47 )
    84 48
    85 49
    86 @numpy.deprecate(new_name="os.makedirs(directory, exist_ok=True)")
    50 @np.deprecate(new_name="os.makedirs(directory, exist_ok=True)")
    87 51 def create_directories_safe(directory, dryrun=False):
  • added 1 commit

    Compare with previous version

  • Can I merge this?

  • I have a MR ready to be merged on bob.bio.face coping with this change

  • I'll merge it and keep going with the deprecation endeavor

  • go ahead please

  • Amir MOHAMMADI mentioned in commit cba205a8

    mentioned in commit cba205a8

  • Please register or sign in to reply
    Loading