Skip to content
Snippets Groups Projects

WebDAV support improvements

Merged André Anjos requested to merge dav-improvements into master
1 unresolved thread

This MR adds support for the clean-betas script, which replaces the ad-hoc solution currently installed on our server.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
10 10
11 11 # Definition of our build pipeline order
12 12 stages:
13 - cleanup
13 14 - build
  • It came to mind, but that would mean the clean-up is only run iff the nightlies succeeds, which may lead to accumulating betas for weeks.

  • I also thought to restricting the cleanup to once a week... Running this every night may break a random installation running at the same time.

    What do you think, @amohammadi?

  • Another option is to do (https://docs.gitlab.com/ee/ci/yaml/#when):

    when: always
  • That may work and I agree it would be "cleaner".

  • It came to mind, but that would mean the clean-up is only run iff the nightlies succeeds, which may lead to accumulating betas for weeks.

    Running clean-ups when nightlies fails breaks our setup untill nightlies is green again. For examples, bob/docs stops working, we cannot create a stable beta environment from the channel anymore and ...

    So I still think it should be run after nightlies is green.

  • OK for me, but I think this will create a very big stress on having green nightlies all the time (or the disk is going full).

  • You can add a manual clean-up stage as well that we can trigger manually in bob.nightlies.

    stages:
      - cleanup_manual
      - build
      - cleanup
    
    cleanup_manual:
      when: manual
  • Let's try that.

  • Please register or sign in to reply
    Loading