Skip to content
Snippets Groups Projects

[bootstrap,deploy] Fix bootstrap and deployment base servers for (internal) CI builds

Merged André Anjos requested to merge fix-etc-host-avoidance into master
2 unresolved threads

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
34 34 ssl_verify: false #!final
35 35 """
36 36
37 _SERVER = "http://www.idiap.ch"
37 _SERVER = "http://bobconda.lab.idiap.ch"
  • Shouldn't that rather be the default value of a command parameter so that it can be changed when needed ?

    That way it could stay the default http://www.idiap.ch so people using it locally would have no issue and it can be configured on the CI using an environment variable.

  • Please register or sign in to reply
  • 11 11
    12 12 # This must be a copy of what is in bootstrap.py.
    13 13 # Notice this script is also called independently of bob.devtools!
    14 _SERVER = "http://www.idiap.ch"
    14 _SERVER = "http://bobconda.lab.idiap.ch"
  • Out of curiosity, why use argparse rather than click for bootstrap.py and deploy.py ?

  • merged

  • André Anjos mentioned in commit 162d1565

    mentioned in commit 162d1565

  • @samuel.gaist: Sorry, I merged this w/o seeing your comments until now. To answer:

    1. curiosity: bootstrap must work standalone (only Python interpreter available), the other scripts may rely on a base installed environment.
    2. defaults: I just wanted to patch this to (temporarily) fix the workflow for packages still using the "old" CI strategy. We are slowly migrating to a much faster Python-package-based CI strategy with the whole code-base as you are aware of. In this sense, I think the idea is we deprecate/stop maintaining this package when possible.

    For the long answer, there is a structural problem with this package as it is trying to solve too many relatively orthogonal problems at the same time: a) handle the CI; b) provide development helpers for local work and c) handle package creation. This created weird issues such as the "fake requirement" to setup the /etc/hosts redirection (since our scripts needed to support all these scenarios). To fix this, specialise better and de-brand as where possible, we're splitting this into 3 packages: bob/citools> (CI-only scripts and build constraints), bob/devtools> (local dev helpers of all sorts), and bob/cookiecutter-pypackage> (creation of new packages). Each will contain only tools required for that particular activity.

  • PS: We should probably try to move these 3 packages above out of the bob/ namespace. May be, the aip would be a good candidate...

  • I understand the points raised and it's a good split that you implemented.

    As for the namespace, shouldn't we rather have something that is project agnostic ?

    I think that using aip will introduce the same branding issue that bob is suffering from.

    I don't have a name in mind yet though. Maybe simply using "Idiap".

  • Right! Good idea. Is there such a group?

  • I mean, can you please go ahead and create such a group so we can start moving stuff there?

  • Please register or sign in to reply
    Loading