Move pre-commit check in its own stage

This is a preliminary implementation of an "optimisation" of the current pipeline.

It's implemented to in a way that takes into account the issue already tackled by !285 (closed).

The goal here is to add a new stage to the pipeline that is responsible for the QA of the code sent.

This will allow the pipeline to fail early on rather than run each and every variation of the build to have them fail for the same reasons. Using such a stage can also remove the quality checks in every build job as it is done prior to that.

This should allow to improve the nightlies build time a bit since the QA would be done once per package rather than once per build job.

added Important label

requested review from @tiago.pereira

assigned to @andre.anjos

added 3 commits

• 370e149b - [gitlab-ci] Move common setup code in global before_script
• 9b15b584 - [gitlab-ci] Remove pre-commit checks from macOS build stages
• 0a342953 - [gitlab-ci] Refactor deploy part to share common elements

Compare with previous version

Hey @samuel.gaist;

Now I understood what you are proposing.

It is a good idea.

Thanks for the MR; I'll close the !285 (closed) in favor of this one and check if I need to update other files.

mentioned in merge request !285 (closed)

added 1 commit

• 6649ce5c - Applying the security [git] fix from 285

Compare with previous version

added 1 commit

• e4db01b2 - Applying the security [git] fix from 285

Compare with previous version

I think we are good to go.

Thank you, gents.

merged

mentioned in commit 40ba1104

What about having this qa phase on all other CI files as well? Not sure why that was not implemented on those...

Yeap, in another MR :-)

@samuel.gaist I think it would have been better to just use a pre-commit or python image here.

@tiago.pereira: this does not work well if the runner is shared (shell executor), as it tends to pollute the global gitconfig indefinitely. Here is an example:

# admin @ cimacos3 in ~ [18:10:05]
$ su - gitlab
Password:
gitlab@cimacos3 ~ % cat .gitconfig
[safe]
	directory = /Users/gitlab/builds/sAZPGTqW/1/bob/bob.devtools
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/bob.devtools
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/bob.devtools
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/bob.devtools
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/bob.devtools
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/bob.devtools
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/bob.devtools
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/bob.fusion.base
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/bob.bio.face
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/bob.ip.binseg
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/bob.pipelines
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/bob.bio.base
	directory = /Users/gitlab/builds/sAZPGTqW/1/bob/bob.bio.base
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/bob.bio.base
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/bob.fusion.base
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/bob.fusion.base
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/bob.bio.base
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/bob.fusion.base
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/bob.bio.spear
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/bob.bio.face
	directory = /Users/gitlab/builds/sAZPGTqW/0/beat/beat.nightlies
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/nightlies
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/bob.db.batl
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/bob.db.batl2
	directory = /Users/gitlab/builds/sAZPGTqW/0/beat/beat.nightlies
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/nightlies
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/bob.db.batl
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/bob.db.batl2
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/nightlies
	directory = /Users/gitlab/builds/sAZPGTqW/0/beat/beat.nightlies
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/bob.db.batl
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/bob.db.batl2
	directory = /Users/gitlab/builds/sAZPGTqW/0/beat/beat.nightlies
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/bob.db.batl
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/bob.db.batl2
	directory = /Users/gitlab/builds/sAZPGTqW/0/beat/beat.nightlies
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/nightlies
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/bob.db.batl
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/bob.db.batl2
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/bob.ip.binseg
	directory = /Users/gitlab/builds/sAZPGTqW/0/bob/bob.bio.spear
	directory = /Users/gitlab/builds/sAZPGTqW/1/bob/bob.devtools
	directory = /Users/gitlab/builds/sAZPGTqW/2/bob/bob.devtools

@tiago.pereira: there is also an unfortunate side effect that breaks the builds: https://gitlab.idiap.ch/bob/bob.devtools/-/jobs/265131

Hi guys, sorry for this noise. I'll patch this modification to affect only linux builds (the container based one).

Furthermore, I'll clean the .gitconfig from the mac machines.

mentioned in merge request !288 (merged)