Skip to content
Snippets Groups Projects

Keep the order of FrameContainers when saving

Merged Keep the order of FrameContainers when saving
p1 into master
All threads resolved!
Merged Amir MOHAMMADI requested to merge p1 into master
All threads resolved!

Fixes #14 (closed)

Merge request reports

Pipeline #25076 passed

Stage: build

Pipeline passed for 8194610d on p1

Test coverage 91.00% from 2 jobs

Merged by Amir MOHAMMADIAmir MOHAMMADI 6 years ago (Nov 27, 2018 1:00pm UTC)

Loading

Pipeline #25077 passed

Stage: build
Stage: deploy

Pipeline passed for e72166cd on master

Test coverage 91.00% from 2 jobs

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Manuel Günther
    Manuel Günther @mguenther ·
    Maintainer

    The rest looks fine to me.

  • Tiago de Freitas Pereira
    Tiago de Freitas Pereira @tiago.pereira ·
    Owner

    If @mguenther says it's fine, I'm good with it

  • Tiago de Freitas Pereira assigned to @amohammadi

    assigned to @amohammadi

  • Tiago de Freitas Pereira
    Tiago de Freitas Pereira @tiago.pereira ·
    Owner

    thanks @mguenther

  • Amir MOHAMMADI added 1 commit

    added 1 commit

    • 12cbd2e6 - Keep the order of FrameContainers when saving

    Compare with previous version

  • Amir MOHAMMADI added 1 commit

    added 1 commit

    • 8194610d - Keep the order of FrameContainers when saving

    Compare with previous version

  • Amir MOHAMMADI
    Amir MOHAMMADI @amohammadi ·
    Author Owner

    Thank you for reviewing. Implemented the changes.

  • Amir MOHAMMADI resolved all discussions

    resolved all discussions

  • Amir MOHAMMADI enabled an automatic merge when the pipeline for 8194610d succeeds

    enabled an automatic merge when the pipeline for 8194610d succeeds

  • Amir MOHAMMADI mentioned in commit e72166cd

    mentioned in commit e72166cd

  • Amir MOHAMMADI merged

    merged

  • Amir MOHAMMADI mentioned in merge request bob.learn.pytorch!23 (merged)

    mentioned in merge request bob.learn.pytorch!23 (merged)

    • Please register or sign in to reply