Output of `dataset.all_samples` is inconsistent
The output of the method all_samples
of different databases returns different things. While the default CSVDataset
https://gitlab.idiap.ch/bob/bob.bio.base/-/blob/997e6d6dda44c928c1792518a2b625726efde0e1/bob/bio/base/database/csv_dataset.py#L744 returns a list of Sample
(more precisely a list of DelayedSample
), some other datasets implemented in here return a list of SampleSet
. Examples are:
- https://gitlab.idiap.ch/bob/bob.bio.face/-/blob/38a910ac1df0ba14e8262f957ae0e666a3e2f616/bob/bio/face/database/ijbc.py#L296
- https://gitlab.idiap.ch/bob/bob.bio.face/-/blob/38a910ac1df0ba14e8262f957ae0e666a3e2f616/bob/bio/face/database/rfw.py#L424
- https://gitlab.idiap.ch/bob/bob.bio.face/-/blob/38a910ac1df0ba14e8262f957ae0e666a3e2f616/bob/bio/face/database/gbu.py#L238
But I am sure that I was missing some.
Is there any plan in changing this inconsistency? The name of the function suggests to extract a list of Sample
, so we would likely want to adapt the implementations of the datasets listed here...