Skip to content
Snippets Groups Projects

makes the annotations method implementation mandatory

Merged Amir MOHAMMADI requested to merge refactoring_2016 into master

move some functionality of bob.bio.base.database.BioDatabase to bob.db.base

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Amir MOHAMMADI enabled an automatic merge when the pipeline for 570ea2a9 succeeds

    enabled an automatic merge when the pipeline for 570ea2a9 succeeds

  • May I ask what this is about? Are we moving biometrics support back to bob.db.base?

  • Note: Not all non-biometric databases incorporate the notion of "annotation".

  • Amir MOHAMMADI mentioned in commit 0614ae82

    mentioned in commit 0614ae82

  • Speaker, for instance, doesn't have annotations. Was this discussed?

  • This is just a small change don't worry.

    Are we moving biometrics support back to bob.db.base?

    No!

    The discussion happened here: bob#235 (closed) The problem was that low-level databases could not take advantage of original_directory and original_extension parameters. Now they have a method called original_file_names in bob.db.base which can be used.

    Another thing is that bob.bio.base supplied a default implementation for annotations but this was really specific to face databases. I fixed the annotations in all databases and to make sure nothing is missing I made annotations method mandatory. This changes are reflected in bob.bio.spear, bob.bio.face, and bob.bio.video. merge requests are coming.

    Other related issues: bob.bio.face#14 (closed) and bob.bio.face!18 (closed)

    Now high-level implementations need to implement annotations which for speaker verification databases would be:

        def annotations(self, file):
            return None

    I have implemented this in all packages except bob.bio.vein. I'll do that too.

Please register or sign in to reply
Loading