Added the memory_demanding attribute as part of the legacy APi (!221) · Merge requests · bob / bob.bio.base · GitLab

Snippets Groups Projects

Merged Tiago de Freitas Pereira requested to merge memory-demanding into master 4 years ago

1 unresolved thread

Activity

Tiago de Freitas Pereira assigned to @amohammadi 4 years ago

assigned to @amohammadi
Amir MOHAMMADI @amohammadi started a thread on the diff 4 years ago

bob/bio/base/pipelines/vanilla_biometrics/legacy.py

81	84	)
82	85	self.annotation_type = annotation_type
83	86	self.fixed_positions = fixed_positions
	87	self.memory_demanding = memory_demanding
Amir MOHAMMADI @amohammadi 4 years ago Owner I like it how you only think about legacy databases to continue to work ;) Tiago de Freitas Pereira @tiago.pereira 4 years ago Author Owner There are so many Amir MOHAMMADI @amohammadi 4 years ago Owner I am thinking we should have not created yet another abstract class for databases. I am getting nightmares because of what we did :D Tiago de Freitas Pereira @tiago.pereira 4 years ago Author Owner I'm constantly having nightmares about all this we've done. Tiago de Freitas Pereira @tiago.pereira 4 years ago Author Owner The situation is different from 4 years ago. Today there are substantially more people that will rely on this. Amir MOHAMMADI @amohammadi 4 years ago Owner man what about your new shiny csvdataset? doesn't that one also need this attribute? Tiago de Freitas Pereira @tiago.pereira 4 years ago Author Owner I'll contemplate it once I find some time to finish this bob.bio.face!81 (merged) Please register or sign in to reply

Tiago de Freitas Pereira @tiago.pereira 4 years ago

Author Owner

I'll set to automerge. I would like to test it with the new features.

Tiago de Freitas Pereira merged 4 years ago

merged

Tiago de Freitas Pereira mentioned in commit 4 years ago

mentioned in commit 9b372043

Please register or sign in to reply