[legacy databases] delay loading of annotations

Depends on bob.pipelines!47 (merged)

bob/bio/base/pipelines/vanilla_biometrics/legacy.py

@@ -3,23 +3,18 @@
 
 """Re-usable blocks for legacy bob.bio.base algorithms"""
 
-import os
 import functools
-from collections import defaultdict
-
-from bob.bio.base import utils
-from .abstract_classes import (
-    BioAlgorithm,
-    Database,
-)
-from bob.io.base import HDF5File
-from bob.pipelines import DelayedSample, SampleSet, Sample, DelayedSampleSet
 import logging
-import copy
-import joblib
-from .score_writers import FourColumnsScoreWriter
+import os
 
+import joblib
 from bob.bio.base.algorithm import Algorithm
+from bob.pipelines import DelayedSample
+from bob.pipelines import DelayedSampleSet
+from bob.pipelines import SampleSet
+
+from .abstract_classes import BioAlgorithm
+from .abstract_classes import Database
 
 logger = logging.getLogger("bob.bio.base")
 
@@ -27,12 +22,16 @@ logger = logging.getLogger("bob.bio.base")
 def _biofile_to_delayed_sample(biofile, database):
     return DelayedSample(
         load=functools.partial(
-            biofile.load, database.original_directory, database.original_extension,
+            biofile.load,
+            database.original_directory,
+            database.original_extension,
         ),
         subject=str(biofile.client_id),
         key=biofile.path,
         path=biofile.path,
-        annotations=database.annotations(biofile),
+        delayed_attributes=dict(
+            annotations=functools.partial(database.annotations, biofile)
+        ),
     )
 
 
@@ -205,7 +204,12 @@ class BioAlgorithmLegacy(BioAlgorithm):
     """
 
     def __init__(
-        self, instance, base_dir, force=False, projector_file=None, **kwargs,
+        self,
+        instance,
+        base_dir,
+        force=False,
+        projector_file=None,
+        **kwargs,
     ):
         super().__init__(**kwargs)
 

[Tiago de Freitas Pereira]

Why don't you like constructions like this?

from bob.pipelines import DelayedSample, SampleSet, Sample, DelayedSampleSet

[Amir MOHAMMADI]

It's not that I don't like it. This is formatted like this automatically using isort --sl

[Tiago de Freitas Pereira]

Ah, ok

[Tiago de Freitas Pereira]

I was just curious

[Amir MOHAMMADI]

@tiago.pereira this depended on bob.pipelines!47 (merged) but that one is still not merged. The fact that this is green means this code is not tested :)