Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • bob.bio.base bob.bio.base
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 15
    • Issues 15
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • bobbob
  • bob.bio.basebob.bio.base
  • Merge requests
  • !113

Removed global variable results

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Tiago de Freitas Pereira requested to merge implemented-recursion into master Nov 08, 2017
  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 1

The script bob.bio.base.scripts.collect_results has global variable called results whose role is to gather the results from several directories.

Would be cleaner and more easy to reuse this module if the results were passed throught the recursions instead of being stored in global variable.

I've just done that.

Do you mind to review that @mguenther?

Thanks

Edited Nov 08, 2017 by Tiago de Freitas Pereira
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: implemented-recursion