Revert "replace the original_directory path in the low-level db too"
This reverts merge request !57 (merged)
Merge request reports
Activity
mentioned in merge request !57 (merged)
@andre.anjos why you should have it as
_db
and not__db
.@andre.anjos Why do you want to revert these changes, after such a long discussion in !57 (merged)?
@amohammadi According to the python coding rules, private variables should be marked with a single
_
. The double__
is reserved for special variables and are handled differently: https://stackoverflow.com/questions/1301346/what-is-the-meaning-of-a-single-and-a-double-underscore-before-an-object-nameI don't think I suggested anything in this issue.
It was just @amohammadi's way to point me to this bug (we still had double underscores in some parts of
bob.bio.vein
).@andre.anjos Oh, this MR is already 4 weeks old. Sorry, I didn't realize that. I thought that you were opening it right now :-O
mentioned in merge request bob.bio.face!36 (merged)
mentioned in merge request bob.bio.video!25 (merged)
mentioned in merge request bob.pad.face!34 (merged)
assigned to @mguenther
@bob I am reverting this and providing a fix for cases that I have seen that this will break it in bob.bio.face!36 (merged) and bob.bio.video!25 (merged), and bob.pad.face!34 (merged).
If you have some high-level database interface somewhere besides the master branches or some package that is not in nightlies, please apply a similar fix to your database interface as well.
mentioned in commit 29ae368a