Usage of --environment is not clear

On the help message says:

  -t [ENV [ENV ...]], --environment [ENV [ENV ...]]
                        Passes specific environment variables to the job.
                        (default: [])

but to get it to work you need to use: verify.py -t "PATH=/mypath" "VARIABLE=001"

Am I right?

That's a good question. I haven't implemented this option, and there is an merge request to remove that option again, which has been merged already: !21 (merged) For some reason this command line option has survived. However, it is not evaluated anymore. We should remove it entirely.

Started branch 47-usage-of-environment-is-not-clear

Mentioned in merge request !47 (closed)

Oh, I see that it is indeed used. Since I have no idea, what is the structure of the parameters passed to --environment, I assign this to Tiago.

Reassigned to @tiago.pereira

Yes I didn't ask for it to be removed. I just wanted the help message to be better.

I know. But I thought that this option was actually reverted in !21 (merged) , so it would be better to remove an unused option, rather than updating its documentation.

However, it turned out that !21 (merged) reverted only a small issue, not the whole command line option. Hence, I have deleted the branch that was deleting this option. Now I have assigned Tiago to do what you actually asked for: update the documentation.

I had comment in this thread.

Did anyone remove by accident?

I don't see any comments from you @tiago.pereira in my emails.

I had a comment saying that I do care about this option and we shouldn't remove

Maybe you commented on the pull !47 (closed) which is weirdly closed. Anyways, this issue is about updating its documentation and nobody wants this feature removed.

I have closed !47 (closed) since I realized that I cannot remove the environment variable as it was not unused. I have also removed the source branch, as it was not working anyways.

changed milestone to %May 2017 Hackathon

I think this is clear enough. I'll close it

closed

@tiago.pereira the help message is still the same:

  -t [ENV [ENV ...]], --environment [ENV [ENV ...]]
                        Passes specific environment variables to the job.
                        (default: [])

reopened

Man, what do you want there??

closed