Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • beat.web beat.web
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 54
    • Issues 54
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • beat
  • beat.webbeat.web
  • Merge requests
  • !404

Refactor accounts (including API/Views) and yearly_revalidation_users command scripts - Centralize and tests accounts emails

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Flavio TARSETTI requested to merge 577_cleanup_yearly_supervision into master Sep 30, 2020
  • Overview 147
  • Commits 13
  • Pipelines 51
  • Changes 42
  • cleaned accounts API
  • cleaned accounts views
  • refactored yearly revalidation scripts
  • removed code duplicates and unified code
  • centralized account actions (i.e.: supervisee rejection, etc.)
  • made sure tests still work
  • centralized emails with an email messaging utility
  • added complete test cases for all emails
  • removed unused emails
  • patched code exceptions
  • simplified inheritance in accounts API
  • improved error management in API with DRF

This MR does a cleanup of the command targeting yearly re-validation of users.

Fixes #577

Edited Nov 17, 2020 by Flavio TARSETTI
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 577_cleanup_yearly_supervision