Perf issue with Angular's 2-way binding makes complex reports unusable

The default two-way binding is too slow right now. Somehow this wasn't caught in testing, even though large reports were tested. It might have to do with the complexity of experiments - if Angular is binding entire experiment/toolchain objects, the perf hit could've slipped through testing.

assigned to @jdiefenbaugh

@jdiefenbaugh: could you please estimate how long until we get this fixed? It is an annoying issue many will hit.

@andre.anjos have you seen this issue at all? Somehow I'm not able to reproduce this locally - everything is working fine (even when setting my internet speeds to "Slow 3G" in Chromium).

@tiago.pereira reported this one.

talked with him more and I think this is actually a performance issue I haven't ran into

Just for posterity, here was my initial diagnosis:

"""

This came up while someone was creating a report on production.

The plots for a group regenerate whenever an alias of an experiment in the group changes, because the plots use the group's aliases as labels. Unfortunately this regeneration is synchronous: every time an alias changes, the plot needs to be regenerated before the user can change the alias again.

This isn't an issue with local & staging testing, because the network speeds are fast enough that we dont notice the time taken to fetch a new plot image. On production, however, it takes ~1-5seconds to receive an updated plot image, and all this time the user cannot continue changing the alias. This leads to a artificially cripplingly slow typing experience, as a user can only type 1 character every few seconds.

To fix, the plot regeneration should be uncoupled from the user input. I honestly thought it was like this already, but apparently not.

Right now, a workaround is to not add plots until after you've finished editing the group experiment aliases.

"""

changed title from Unsync report alias changes with plot regeneration to Perf issue with Angular's 2-way binding makes complex reports unusable

changed the description

Here's two firefox performance profiles comparing a before & after of what I've done so far for this:

baseline.json

after_changes.json

And here's the two flame charts:

Baseline:

After the changes:

Changes:

• Debounced ng-model updates by 100-500ms
• Added track bys to almost every ng-repeat directive
• Stopped using a very frequently called function, isUniqueTableable(), because nothing was actually using the function's output
• Memoized other very frequently called functions - tableables() and getFieldType()

mentioned in commit 5bf284ed

mentioned in merge request !234 (merged)

mentioned in commit 706a3c75

mentioned in commit ab5a1a28

closed via commit fcea6b29

closed via merge request !234 (merged)

mentioned in commit fcea6b29