dont dep on globals, misc style fixes for factories

beat/web/reports/static/reports/app/factories/dataFactory.js

@@ -20,7 +20,7 @@
  * with the BEAT platform. If not, see http://www.gnu.org/licenses/.
  */
 //This factory retrieves data from the static files and associates it with the $scope
-app.factory('dataFactory', function($http){
+angular.module('reportApp').factory('dataFactory', function($http){
 	var getData = function (URL) {
 		//return $http.get(URL + 'itemcontent.json');
 		var obj = {content:null};

beat/web/reports/static/reports/app/factories/experimentFactory.js

@@ -20,7 +20,7 @@
  * with the BEAT platform. If not, see http://www.gnu.org/licenses/.
  */
 //This factory retrieves data from the REST API and associates it with the $scope
-app.factory('experimentFactory', function($http, $q){
+angular.module('reportApp').factory('experimentFactory', function($http, $q){
 	return {
 		getExperimentInformation: function (url_prefix, experiment_id){
 			urlBase = url_prefix + '/api/v1/experiments';
@@ -45,6 +45,5 @@ app.factory('experimentFactory', function($http, $q){
 				return response.data;
 			});
 		}
-
-	}
+	};
 });

beat/web/reports/static/reports/app/factories/plotterFactory.js

@@ -20,7 +20,7 @@
  * with the BEAT platform. If not, see http://www.gnu.org/licenses/.
  */
 //This factory retrieves data from the REST API and associates it with the $scope
-app.factory('plotterFactory', ['$http', function($http){
+angular.module('reportApp').factory('plotterFactory', ['$http', function($http){
 	var plotterFactory = {};
 
 	plotterFactory.getPlotters = function (url_prefix){

beat/web/reports/static/reports/app/factories/reportFactory.js

@@ -20,7 +20,7 @@
  * with the BEAT platform. If not, see http://www.gnu.org/licenses/.
  */
 //This factory retrieves data from the REST API and associates it with the $scope
-app.factory('reportFactory', ['$http', 'experimentFactory', function($http, experimentFactory) {
+angular.module('reportApp').factory('reportFactory', ['$http', 'experimentFactory', function($http, experimentFactory) {
 	var urlBase = '/api/v1/reports';
 	var reportFactory = {};
 
@@ -43,8 +43,7 @@ app.factory('reportFactory', ['$http', 'experimentFactory', function($http, expe
 			url: urlBase + '/' + user + '/' + report_id + '/',
 			method: "PUT",
 			data: reportData,
-		})
-
+		});
 	};
 
 	reportFactory.lockReport = function (user, report_id, url_prefix){
@@ -56,8 +55,7 @@ app.factory('reportFactory', ['$http', 'experimentFactory', function($http, expe
 			url: urlBase + '/' + user + '/' + report_id + '/lock/',
 			method: "POST",
 			//data: reportData,
-		})
-
+		});
 	};
 
 	reportFactory.publishReport = function (url_prefix, user, report_id, reportData){
@@ -69,8 +67,7 @@ app.factory('reportFactory', ['$http', 'experimentFactory', function($http, expe
 			url: urlBase + '/' + user + '/' + report_id + '/publish/',
 			method: "POST",
 			data: reportData,
-		})
-
+		});
 	};
 
 	reportFactory.publishReportAlgorithms = function (user, report_id, url_prefix){
@@ -82,8 +79,7 @@ app.factory('reportFactory', ['$http', 'experimentFactory', function($http, expe
 			url: urlBase + '/' + user + '/' + report_id + '/algorithms/',
 			method: "GET",
 			//data: reportData,
-		})
-
+		});
 	};
 
 	reportFactory.removeExperiment = function (user, report_id, experiment, url_prefix){
@@ -95,8 +91,7 @@ app.factory('reportFactory', ['$http', 'experimentFactory', function($http, expe
 			url: urlBase + '/' + user + '/' + report_id + '/remove/',
 			method: "POST",
 			data: experiment,
-		})
-
+		});
 	};
 
 	return reportFactory;