Skip to content
Snippets Groups Projects
Commit 5179668e authored by Samuel GAIST's avatar Samuel GAIST Committed by Samuel GAIST
Browse files

[dataformats][serializers] Pre-commit cleanup

parent fa593ead
No related branches found
No related tags found
No related merge requests found
This commit is part of merge request !327. Comments created here will be created in the context of that merge request.
...@@ -27,7 +27,12 @@ ...@@ -27,7 +27,12 @@
from rest_framework import serializers from rest_framework import serializers
from ..common.serializers import ContributionSerializer, VersionableSerializer, DynamicFieldsSerializer, ContributionCreationSerializer from ..common.serializers import (
ContributionSerializer,
VersionableSerializer,
DynamicFieldsSerializer,
ContributionCreationSerializer,
)
from ..algorithms.models import Algorithm from ..algorithms.models import Algorithm
from ..databases.models import Database, DatabaseSet from ..databases.models import Database, DatabaseSet
...@@ -36,7 +41,7 @@ from .models import DataFormat ...@@ -36,7 +41,7 @@ from .models import DataFormat
import beat.core.dataformat import beat.core.dataformat
#---------------------------------------------------------- # ----------------------------------------------------------
class DataFormatCreationSerializer(ContributionCreationSerializer): class DataFormatCreationSerializer(ContributionCreationSerializer):
...@@ -45,7 +50,7 @@ class DataFormatCreationSerializer(ContributionCreationSerializer): ...@@ -45,7 +50,7 @@ class DataFormatCreationSerializer(ContributionCreationSerializer):
beat_core_class = beat.core.dataformat beat_core_class = beat.core.dataformat
#---------------------------------------------------------- # ----------------------------------------------------------
class BaseSerializer(DynamicFieldsSerializer): class BaseSerializer(DynamicFieldsSerializer):
...@@ -53,37 +58,37 @@ class BaseSerializer(DynamicFieldsSerializer): ...@@ -53,37 +58,37 @@ class BaseSerializer(DynamicFieldsSerializer):
accessibility = serializers.SerializerMethodField() accessibility = serializers.SerializerMethodField()
class Meta(DynamicFieldsSerializer.Meta): class Meta(DynamicFieldsSerializer.Meta):
fields = '__all__' fields = "__all__"
default_fields = ['name', 'short_description', 'accessibility'] default_fields = ["name", "short_description", "accessibility"]
def get_accessibility(self, obj): def get_accessibility(self, obj):
return obj.get_sharing_display().lower() return obj.get_sharing_display().lower()
#---------------------------------------------------------- # ----------------------------------------------------------
class ReferencedDataFormatSerializer(BaseSerializer): class ReferencedDataFormatSerializer(BaseSerializer):
class Meta(BaseSerializer.Meta): class Meta(BaseSerializer.Meta):
model = DataFormat model = DataFormat
default_fields = BaseSerializer.Meta.default_fields + ['creation_date'] default_fields = BaseSerializer.Meta.default_fields + ["creation_date"]
#---------------------------------------------------------- # ----------------------------------------------------------
class ReferencingSerializer(BaseSerializer): class ReferencingSerializer(BaseSerializer):
is_owner = serializers.SerializerMethodField() is_owner = serializers.SerializerMethodField()
class Meta(BaseSerializer.Meta): class Meta(BaseSerializer.Meta):
default_fields = BaseSerializer.Meta.default_fields + ['is_owner', 'version',] default_fields = BaseSerializer.Meta.default_fields + ["is_owner", "version"]
def get_is_owner(self, obj): def get_is_owner(self, obj):
if hasattr(obj, 'author'): if hasattr(obj, "author"):
return obj.author == self.context.get('user') return obj.author == self.context.get("user")
#---------------------------------------------------------- # ----------------------------------------------------------
class ReferencingDataFormatSerializer(ReferencingSerializer): class ReferencingDataFormatSerializer(ReferencingSerializer):
...@@ -91,7 +96,7 @@ class ReferencingDataFormatSerializer(ReferencingSerializer): ...@@ -91,7 +96,7 @@ class ReferencingDataFormatSerializer(ReferencingSerializer):
model = DataFormat model = DataFormat
#---------------------------------------------------------- # ----------------------------------------------------------
class ReferencingAlgorithmSerializer(ReferencingSerializer): class ReferencingAlgorithmSerializer(ReferencingSerializer):
...@@ -99,59 +104,78 @@ class ReferencingAlgorithmSerializer(ReferencingSerializer): ...@@ -99,59 +104,78 @@ class ReferencingAlgorithmSerializer(ReferencingSerializer):
model = Algorithm model = Algorithm
#---------------------------------------------------------- # ----------------------------------------------------------
class ReferencingDatabaseSerializer(VersionableSerializer): class ReferencingDatabaseSerializer(VersionableSerializer):
class Meta: class Meta:
model = Database model = Database
default_fields = ['name', 'short_description'] default_fields = ["name", "short_description"]
#---------------------------------------------------------- # ----------------------------------------------------------
class DataFormatSerializer(ContributionSerializer): class DataFormatSerializer(ContributionSerializer):
extend = serializers.SerializerMethodField() extend = serializers.SerializerMethodField()
referenced_dataformats = ReferencedDataFormatSerializer(many=True, source="referenced_formats") referenced_dataformats = ReferencedDataFormatSerializer(
needed_dataformats = ReferencedDataFormatSerializer(many=True, source='all_needed_dataformats') many=True, source="referenced_formats"
)
needed_dataformats = ReferencedDataFormatSerializer(
many=True, source="all_needed_dataformats"
)
referencing_dataformats = serializers.SerializerMethodField() referencing_dataformats = serializers.SerializerMethodField()
referencing_algorithms = serializers.SerializerMethodField() referencing_algorithms = serializers.SerializerMethodField()
referencing_databases = serializers.SerializerMethodField() referencing_databases = serializers.SerializerMethodField()
class Meta(ContributionSerializer.Meta): class Meta(ContributionSerializer.Meta):
model = DataFormat model = DataFormat
default_fields = ContributionSerializer.Meta.default_fields + ['extend'] default_fields = ContributionSerializer.Meta.default_fields + ["extend"]
def get_extend(self, obj): def get_extend(self, obj):
return obj.extend.fullname() if obj.extend else None return obj.extend.fullname() if obj.extend else None
def get_referencing_dataformats(self, obj): def get_referencing_dataformats(self, obj):
user = self.context.get('user') user = self.context.get("user")
dataformats = obj.referencing.for_user(user, True) dataformats = obj.referencing.for_user(user, True)
serializer = ReferencingDataFormatSerializer(dataformats, many=True, context=self.context) serializer = ReferencingDataFormatSerializer(
dataformats, many=True, context=self.context
)
return serializer.data return serializer.data
def get_referencing_algorithms(self, obj): def get_referencing_algorithms(self, obj):
user = self.context.get('user') user = self.context.get("user")
algorithms = Algorithm.objects.for_user(user, True).filter(endpoints=obj.algorithm_endpoints.all()).distinct() algorithms = (
serializer = ReferencingAlgorithmSerializer(algorithms, many=True, context=self.context) Algorithm.objects.for_user(user, True)
.filter(endpoints=obj.algorithm_endpoints.all())
.distinct()
)
serializer = ReferencingAlgorithmSerializer(
algorithms, many=True, context=self.context
)
return serializer.data return serializer.data
def get_referencing_databases(self, obj): def get_referencing_databases(self, obj):
databaseset = DatabaseSet.objects.filter(template__outputs=obj.database_outputs.distinct()) databaseset = DatabaseSet.objects.filter(
databases = Database.objects.filter(protocols__sets=databaseset).distinct().order_by('name') template__outputs=obj.database_outputs.distinct()
serializer = ReferencingDatabaseSerializer(databases, many=True, context=self.context) )
databases = (
Database.objects.filter(protocols__sets=databaseset)
.distinct()
.order_by("name")
)
serializer = ReferencingDatabaseSerializer(
databases, many=True, context=self.context
)
return serializer.data return serializer.data
#---------------------------------------------------------- # ----------------------------------------------------------
class FullDataFormatSerializer(DataFormatSerializer): class FullDataFormatSerializer(DataFormatSerializer):
class Meta(DataFormatSerializer.Meta): class Meta(DataFormatSerializer.Meta):
default_fields = DataFormatSerializer.Meta.default_fields + DataFormatSerializer.Meta.extra_fields default_fields = (
DataFormatSerializer.Meta.default_fields
+ DataFormatSerializer.Meta.extra_fields
)
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment